Skip to content

Commit 5f0bbe0

Browse files
committed
rename pins, write app, write docker
1 parent a019f5d commit 5f0bbe0

6 files changed

Lines changed: 31 additions & 81 deletions

File tree

vetiver/handlers/sklearn.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
import pandas as pd
22
import sklearn
33

4+
from ..meta import _model_meta
45
from .base import VetiverHandler
5-
from ..meta import vetiver_meta
6+
67

78
class SKLearnHandler(VetiverHandler):
89
"""Handler class for creating VetiverModels with sklearn.
@@ -12,14 +13,14 @@ class SKLearnHandler(VetiverHandler):
1213
model : sklearn.base.BaseEstimator
1314
a trained sklearn model
1415
"""
16+
1517
base_class = sklearn.base.BaseEstimator
16-
18+
1719
def __init__(self, model, ptype_data):
1820
super().__init__(model, ptype_data)
1921

2022
def describe(self):
21-
"""Create description for sklearn model
22-
"""
23+
"""Create description for sklearn model"""
2324
desc = f"Scikit-learn {self.model.__class__} model"
2425
return desc
2526

@@ -31,11 +32,10 @@ def construct_meta(
3132
):
3233
"""Create metadata for sklearn model"""
3334
required_pkgs = required_pkgs + ["scikit-learn"]
34-
meta = vetiver_meta(user, version, url, required_pkgs)
35+
meta = _model_meta(user, version, url, required_pkgs)
3536

3637
return meta
3738

38-
3939
def handler_predict(self, input_data, check_ptype):
4040
"""Generates method for /predict endpoint in VetiverAPI
4141
@@ -58,7 +58,7 @@ def handler_predict(self, input_data, check_ptype):
5858
if isinstance(input_data, pd.DataFrame):
5959
prediction = self.model.predict(input_data)
6060
else:
61-
prediction = self.model.predict([input_data])
61+
prediction = self.model.predict([input_data])
6262

6363
# do not check ptype
6464
else:

vetiver/handlers/torch.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import numpy as np
22

3+
from ..meta import _model_meta
34
from .base import VetiverHandler
4-
from ..meta import vetiver_meta
55

66
torch_exists = True
77
try:
@@ -18,13 +18,14 @@ class TorchHandler(VetiverHandler):
1818
model : nn.Module
1919
a trained torch model
2020
"""
21+
2122
base_class = torch.nn.Module
23+
2224
def __init__(self, model, ptype_data):
2325
super().__init__(model, ptype_data)
2426

2527
def describe(self):
26-
"""Create description for torch model
27-
"""
28+
"""Create description for torch model"""
2829
desc = f"Pytorch model of type {type(self.model)}"
2930
return desc
3031

@@ -34,10 +35,9 @@ def create_meta(
3435
url: str = None,
3536
required_pkgs: list = [],
3637
):
37-
"""Create metadata for torch model
38-
"""
38+
"""Create metadata for torch model"""
3939
required_pkgs = required_pkgs + ["torch"]
40-
meta = vetiver_meta(user, version, url, required_pkgs)
40+
meta = _model_meta(user, version, url, required_pkgs)
4141

4242
return meta
4343

@@ -62,9 +62,9 @@ def handler_predict(self, input_data, check_ptype):
6262
if check_ptype == True:
6363
input_data = np.array(input_data, dtype=np.array(self.ptype_data).dtype)
6464
prediction = self.model(torch.from_numpy(input_data))
65-
65+
6666
# do not check ptype
67-
else:
67+
else:
6868
input_data = torch.tensor(input_data)
6969
prediction = self.model(input_data)
7070

vetiver/pin_read_write.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import pydantic
21
import pins
32
import warnings
43
import json

vetiver/tests/test_build_vetiver_model.py

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1+
from numpy import isin
12
import pytest
3+
import sklearn
24

3-
from vetiver.vetiver_model import VetiverModel
5+
import vetiver as vt
46
from vetiver.mock import get_mock_data, get_mock_model
5-
from vetiver.pin_read_write import pin_write
67

78
import pandas as pd
89
import pydantic
@@ -16,7 +17,7 @@
1617

1718
def test_vetiver_model_array_ptype():
1819
# build VetiverModel, no ptype
19-
vt1 = VetiverModel(
20+
vt1 = vt.VetiverModel(
2021
model=model,
2122
ptype_data=X_array,
2223
model_name="iris",
@@ -32,7 +33,7 @@ def test_vetiver_model_array_ptype():
3233

3334
def test_vetiver_model_df_ptype():
3435
# build VetiverModel, df ptype_data
35-
vt2 = VetiverModel(
36+
vt2 = vt.VetiverModel(
3637
model=model,
3738
ptype_data=X_df,
3839
model_name="iris",
@@ -48,7 +49,7 @@ def test_vetiver_model_df_ptype():
4849

4950
def test_vetiver_model_dict_ptype():
5051
dict_data = {"B": 0, "C": 0, "D": 0}
51-
vt3 = VetiverModel(
52+
vt3 = vt.VetiverModel(
5253
model=model,
5354
ptype_data=dict_data,
5455
model_name="iris",
@@ -64,7 +65,7 @@ def test_vetiver_model_dict_ptype():
6465

6566
def test_vetiver_model_no_ptype():
6667
# build VetiverModel, no ptype
67-
vt4 = VetiverModel(
68+
vt4 = vt.VetiverModel(
6869
model=model,
6970
ptype_data=None,
7071
model_name="iris",
@@ -78,18 +79,18 @@ def test_vetiver_model_no_ptype():
7879

7980
def test_vetiver_model_from_pin():
8081

81-
v = VetiverModel(
82+
v = vt.VetiverModel(
8283
model=model,
83-
ptype_data=None,
84-
model_name="iris",
84+
ptype_data=X_df,
85+
model_name="model",
8586
versioned=None,
8687
description=None,
8788
metadata=None,
8889
)
8990
board = pins.board_temp(allow_pickle_read=True)
90-
vetiver_pin_write(board=board, model=v)
91-
v = VetiverModel.from_pin(board, "model")
92-
assert isinstance(v, VetiverModel)
93-
assert vt5.model == model
94-
assert isinstance(vt5.ptype.construct(), pydantic.BaseModel)
91+
vt.vetiver_pin_write(board=board, model=v)
92+
v2 = vt.VetiverModel.from_pin(board, "model")
93+
assert isinstance(v2, vt.VetiverModel)
94+
assert isinstance(v2.model, sklearn.base.BaseEstimator)
95+
assert isinstance(v2.ptype.construct(), pydantic.BaseModel)
9596
board.pin_delete("model")

vetiver/tests/test_pin_read.py

Lines changed: 0 additions & 50 deletions
This file was deleted.

vetiver/tests/test_pin_write.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import pytest
22

33
from vetiver.mock import get_mock_data, get_mock_model
4-
from vetiver.pin_read_write import vetiver_pin_read, vetiver_pin_write
4+
from vetiver.pin_read_write import vetiver_pin_write
55
from vetiver.vetiver_model import VetiverModel
66
import sklearn
77
import pins

0 commit comments

Comments
 (0)