Skip to content

Commit 5a4a421

Browse files
committed
changes from suggestions
1 parent c2628a4 commit 5a4a421

2 files changed

Lines changed: 10 additions & 20 deletions

File tree

vetiver/pin_read_write.py

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -77,23 +77,10 @@ def vetiver_pin_read(board, name: str, version: str = None) -> VetiverModel:
7777
version if version is not None else _choose_version(board.pin_versions(name))
7878
)
7979

80-
model = board.pin_read(name, version)
81-
meta = board.pin_meta(name)
82-
83-
v = VetiverModel(
84-
model=model,
85-
model_name=name,
86-
description=meta.description,
87-
metadata=_model_meta(
88-
user=meta.user,
89-
version=version,
90-
url=meta.user.get("url"), # None all the time, besides Connect
91-
required_pkgs=meta.user.get("required_pkgs"),
92-
),
93-
ptype_data=json.loads(meta.user.get("ptype"))
94-
if meta.user.get("ptype")
95-
else None,
96-
versioned=True,
80+
v = VetiverModel.from_pin(
81+
board = board,
82+
name = name,
83+
version = version
9784
)
9885

9986
return v

vetiver/write_fastapi.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def _choose_version(df: pd.DataFrame):
1717
version_desc = df.sort_values(by="created", ascending=False)
1818
version = version_desc.version[0]
1919
else:
20-
version = df.version[0]
20+
version = df.version[-1]
2121
warnings.warn(
2222
f"""Pinned vetiver model has no active version and no datetime on versions,
2323
Do you need to check your pinned model?
@@ -51,7 +51,7 @@ def vetiver_write_app(board, pin_name: str, version: str = None, file: str = "ap
5151
return write_app(board=board, pin_name=pin_name, version=version, file=file)
5252

5353

54-
def write_app(board, pin_name: str, version: str = None, file: str = "app.py"):
54+
def write_app(board, pin_name: str, version: str = None, file: str = "app.py", overwrite = False):
5555
"""Write VetiverAPI app to a file
5656
5757
Args
@@ -79,7 +79,10 @@ def write_app(board, pin_name: str, version: str = None, file: str = "app.py"):
7979

8080
load_board = pins.board_deparse(board)
8181

82-
f = open(file, "x")
82+
if overwrite:
83+
f = open(file, "w")
84+
elif not overwrite:
85+
f = open(file, "x")
8386

8487
app = f"""from vetiver import VetiverModel
8588
{_glue_required_pkgs(infra_pkgs)}

0 commit comments

Comments
 (0)