update write_app tests to avoid protocol mismatch

Author: isabelizimm

vetiver/tests/test_prepare_docker.py

@@ -32,6 +32,14 @@ def create_vetiver_model():
     return vetiver.VetiverModel(model.fit(X, y), "model", prototype_data=X)
 
 
+def test_warning_if_no_protocol(create_vetiver_model):
+    with pytest.warns(UserWarning):
+        board = pins.board_temp(allow_pickle_read=True)
+        board.fs.protocol = "abc"
+
+        vetiver.get_board_pkgs(board)
+
+
 @pytest.mark.parametrize(
     "prot,output",
     [
@@ -51,11 +59,3 @@ def test_get_board_pkgs(prot, output, create_vetiver_model):
         file = Path(tempdir, "vetiver_requirements.txt")
         contents = open(file).read()
         assert f"{output}==" in contents
-
-
-def test_warning_if_no_protocol(create_vetiver_model):
-    with pytest.warns(UserWarning):
-        board = pins.board_temp(allow_pickle_read=True)
-        board.fs.protocol = "abc"
-
-        vetiver.get_board_pkgs(board)

vetiver/tests/test_write_app.py

@@ -1,38 +1,39 @@
-import os
 import pins
 import vetiver
+import pytest
+from tempfile import TemporaryDirectory
+from pathlib import Path
 
-# Load data, model
-X_df, y = vetiver.get_mock_data()
-model = vetiver.get_mock_model().fit(X_df, y)
 
+@pytest.fixture
+def vetiver_model_creation():
+    X_df, y = vetiver.get_mock_data()
+    model = vetiver.get_mock_model().fit(X_df, y)
+    return vetiver.VetiverModel(model, "model")
 
-def test_write_app():
-    file = "app.py"
-    v = vetiver.VetiverModel(
-        model=model, prototype_data=X_df, model_name="model", versioned=None
-    )
-    model_board = pins.board_folder(path=".", versioned=True, allow_pickle_read=True)
-    vetiver.vetiver_pin_write(board=model_board, model=v)
-    vetiver.write_app(model_board, "model", file="app.py")
-    contents = open(file).read()
-    os.remove(file)
-    version = model_board.pin_versions("model").sort_values(
-        by="created", ascending=False
-    )
-    version = version.version[0]
-    assert (
-        contents
-        == f"""from vetiver import VetiverModel
+
+def test_write_app(vetiver_model_creation):
+    with TemporaryDirectory() as tempdir:
+        file = Path(tempdir, "app.py")
+        model_board = pins.board_folder(path=tempdir, allow_pickle_read=True)
+        vetiver.vetiver_pin_write(model_board, vetiver_model_creation)
+        vetiver.write_app(model_board, "model", file=file)
+        contents = open(file).read()
+        version = model_board.pin_versions("model").sort_values(
+            by="created", ascending=False
+        )
+        version = version.version[0]
+        assert (
+            contents
+            == f"""from vetiver import VetiverModel
 import vetiver
 import pins
 
 
-b = pins.board_folder('.', allow_pickle_read=True)
-v = VetiverModel.from_pin(b, 'model', version = '{version}')
+b = pins.board_folder({repr(tempdir)}, allow_pickle_read=True)
+v = VetiverModel.from_pin(b, 'model', version = {repr(version)})
 
 vetiver_api = vetiver.VetiverAPI(v)
 api = vetiver_api.app
 """
-    )
-    model_board.pin_delete("model")
+        )