Skip to content

Commit 8952500

Browse files
cpcloudnealrichardson
authored andcommitted
chore: take advantage of existing context managers
1 parent 2777cae commit 8952500

1 file changed

Lines changed: 2 additions & 8 deletions

File tree

pins/boards.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -790,16 +790,13 @@ def _load_data(self, meta, pin_version_path):
790790

791791
@contextlib.contextmanager
792792
def _open_pin_meta(self, path):
793-
f = self.fs.open(path)
794-
try:
793+
with self.fs.open(path) as f:
795794
self._touch_cache(path)
796795

797796
# optional additional data to put in Meta.local
798797
local = {}
799798

800799
yield f, local
801-
finally:
802-
self.fs.close(f)
803800

804801
def _get_cache_path(self, pin_name, version=None, fname=None):
805802
version_part = [version] if version is not None else []
@@ -1149,8 +1146,7 @@ def pin_versions_prune(self, *args, **kwargs):
11491146

11501147
@contextlib.contextmanager
11511148
def _open_pin_meta(self, path):
1152-
f = self.fs.open(path)
1153-
try:
1149+
with self.fs.open(path) as f:
11541150
self._touch_cache(path)
11551151

11561152
# optional additional data to put in Meta.local
@@ -1165,8 +1161,6 @@ def _open_pin_meta(self, path):
11651161
}
11661162

11671163
yield f, local
1168-
finally:
1169-
self.fs.close(f)
11701164

11711165
def validate_pin_name(self, name) -> None:
11721166
# this should be the default behavior, expecting a full pin name.

0 commit comments

Comments
 (0)