Skip to content

Commit d6ad3a0

Browse files
Kefeng Wanggregkh
authored andcommitted
tty/serial: digicolor: Fix digicolor-usart already registered warning
[ Upstream commit c7ad9ba ] When modprobe/rmmod/modprobe module, if platform_driver_register() fails, the kernel complained, proc_dir_entry 'driver/digicolor-usart' already registered WARNING: CPU: 1 PID: 5636 at fs/proc/generic.c:360 proc_register+0x19d/0x270 Fix this by adding uart_unregister_driver() when platform_driver_register() fails. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> Acked-by: Baruch Siach <baruch@tkos.co.il> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent d72a857 commit d6ad3a0

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

drivers/tty/serial/digicolor-usart.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,11 @@ static int __init digicolor_uart_init(void)
544544
if (ret)
545545
return ret;
546546

547-
return platform_driver_register(&digicolor_uart_platform);
547+
ret = platform_driver_register(&digicolor_uart_platform);
548+
if (ret)
549+
uart_unregister_driver(&digicolor_uart);
550+
551+
return ret;
548552
}
549553
module_init(digicolor_uart_init);
550554

0 commit comments

Comments
 (0)