Skip to content

Commit 345f195

Browse files
tasksetgregkh
authored andcommitted
pinctrl: rockchip: fix leaked of_node references
[ Upstream commit 3c89c70 ] The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./drivers/pinctrl/pinctrl-rockchip.c:3221:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3196, but without a corresponding object release within this function. ./drivers/pinctrl/pinctrl-rockchip.c:3223:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3196, but without a corresponding object release within this function. Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Heiko Stuebner <heiko@sntech.de> Cc: linux-gpio@vger.kernel.org Cc: linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent d11053e commit 345f195

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/pinctrl/pinctrl-rockchip.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1837,6 +1837,7 @@ static int rockchip_get_bank_data(struct rockchip_pin_bank *bank,
18371837
base,
18381838
&rockchip_regmap_config);
18391839
}
1840+
of_node_put(node);
18401841
}
18411842

18421843
bank->irq = irq_of_parse_and_map(bank->of_node, 0);

0 commit comments

Comments
 (0)