Skip to content

Commit e310b2b

Browse files
committed
Improve BatchRepositoryTests
3.0-preview
1 parent cfd11ea commit e310b2b

1 file changed

Lines changed: 13 additions & 16 deletions

File tree

Tests/CoreDataRepositoryTests/BatchRepositoryTests.swift

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ import XCTest
1313

1414
final class BatchRepositoryTests: CoreDataXCTestCase {
1515
let movies: [[String: Any]] = [
16-
["id": UUID(), "title": "A", "releaseDate": Date()],
17-
["id": UUID(), "title": "B", "releaseDate": Date()],
18-
["id": UUID(), "title": "C", "releaseDate": Date()],
19-
["id": UUID(), "title": "D", "releaseDate": Date()],
20-
["id": UUID(), "title": "E", "releaseDate": Date()],
16+
["id": UUID(uniform: "A"), "title": "A", "releaseDate": Date(timeIntervalSinceReferenceDate: 0)],
17+
["id": UUID(uniform: "B"), "title": "B", "releaseDate": Date(timeIntervalSinceReferenceDate: 1)],
18+
["id": UUID(uniform: "C"), "title": "C", "releaseDate": Date(timeIntervalSinceReferenceDate: 2)],
19+
["id": UUID(uniform: "D"), "title": "D", "releaseDate": Date(timeIntervalSinceReferenceDate: 3)],
20+
["id": UUID(uniform: "E"), "title": "E", "releaseDate": Date(timeIntervalSinceReferenceDate: 4)],
2121
]
2222
let failureInsertMovies: [[String: Any]] = [
2323
["id": "A", "title": 1, "releaseDate": "A"],
@@ -26,16 +26,13 @@ final class BatchRepositoryTests: CoreDataXCTestCase {
2626
["id": "D", "title": 4, "releaseDate": "D"],
2727
["id": "E", "title": 5, "releaseDate": "E"],
2828
]
29-
let failureCreateMovies: [[String: Any]] = {
30-
let id = UUID()
31-
return [
32-
["id": id, "title": "A", "releaseDate": Date()],
33-
["id": id, "title": "B", "releaseDate": Date()],
34-
["id": id, "title": "C", "releaseDate": Date()],
35-
["id": id, "title": "D", "releaseDate": Date()],
36-
["id": id, "title": "E", "releaseDate": Date()],
37-
]
38-
}()
29+
let failureCreateMovies: [[String: Any]] = [
30+
["id": UUID(uniform: "A"), "title": "A", "releaseDate": Date()],
31+
["id": UUID(uniform: "A"), "title": "B", "releaseDate": Date()],
32+
["id": UUID(uniform: "A"), "title": "C", "releaseDate": Date()],
33+
["id": UUID(uniform: "A"), "title": "D", "releaseDate": Date()],
34+
["id": UUID(uniform: "A"), "title": "E", "releaseDate": Date()],
35+
]
3936

4037
func mapDictToManagedMovie(_ dict: [String: Any]) throws -> ManagedMovie {
4138
try mapDictToMovie(dict)
@@ -297,7 +294,7 @@ final class BatchRepositoryTests: CoreDataXCTestCase {
297294
XCTAssertEqual(result.success.count, movies.count)
298295
XCTAssertEqual(result.failed.count, 0)
299296

300-
XCTAssertEqual(Set(editedMovies), Set(result.success))
297+
XCTAssertNoDifference(Set(editedMovies), Set(result.success))
301298

302299
try verify(transactionAuthor: transactionAuthor, timeStamp: historyTimeStamp)
303300
}

0 commit comments

Comments
 (0)