Fix application of transactionAuthor to repository context in all editing functions

transaction-author-is-not-applied-to-the-context-for-some-functions

Author: roanutil

Sources/CoreDataRepository/CoreDataRepository+Batch.swift

@@ -22,11 +22,13 @@ extension CoreDataRepository {
         _ request: NSBatchInsertRequest,
         transactionAuthor: String? = nil
     ) async -> Result<NSBatchInsertResult, CoreDataRepositoryError> {
-        await context.performInScratchPad { scratchPad in
-            scratchPad.transactionAuthor = transactionAuthor
+        await context.performInScratchPad { [context] scratchPad in
+            context.transactionAuthor = transactionAuthor
             guard let result = try scratchPad.execute(request) as? NSBatchInsertResult else {
+                context.transactionAuthor = nil
                 throw CoreDataRepositoryError.fetchedObjectFailedToCastToExpectedType
             }
+            context.transactionAuthor = nil
             return result
         }
     }
@@ -127,11 +129,13 @@ extension CoreDataRepository {
         _ request: NSBatchUpdateRequest,
         transactionAuthor: String? = nil
     ) async -> Result<NSBatchUpdateResult, CoreDataRepositoryError> {
-        await context.performInScratchPad { scratchPad in
-            scratchPad.transactionAuthor = transactionAuthor
+        await context.performInScratchPad { [context] scratchPad in
+            context.transactionAuthor = transactionAuthor
             guard let result = try scratchPad.execute(request) as? NSBatchUpdateResult else {
+                context.transactionAuthor = nil
                 throw CoreDataRepositoryError.fetchedObjectFailedToCastToExpectedType
             }
+            context.transactionAuthor = nil
             return result
         }
     }
@@ -193,11 +197,13 @@ extension CoreDataRepository {
         _ request: NSBatchDeleteRequest,
         transactionAuthor: String? = nil
     ) async -> Result<NSBatchDeleteResult, CoreDataRepositoryError> {
-        await context.performInScratchPad { scratchPad in
-            scratchPad.transactionAuthor = transactionAuthor
+        await context.performInScratchPad { [context] scratchPad in
+            context.transactionAuthor = transactionAuthor
             guard let result = try scratchPad.execute(request) as? NSBatchDeleteResult else {
+                context.transactionAuthor = nil
                 throw CoreDataRepositoryError.fetchedObjectFailedToCastToExpectedType
             }
+            context.transactionAuthor = nil
             return result
         }
     }

Sources/CoreDataRepository/CoreDataRepository+CRUD.swift

@@ -27,12 +27,13 @@ extension CoreDataRepository {
         transactionAuthor: String? = nil
     ) async -> Result<Model, CoreDataRepositoryError> {
         await context.performInScratchPad(schedule: .enqueued) { [context] scratchPad in
-            scratchPad.transactionAuthor = transactionAuthor
             let object = Model.RepoManaged(context: scratchPad)
             object.create(from: item)
             try scratchPad.save()
             try context.performAndWait {
+                context.transactionAuthor = transactionAuthor
                 try context.save()
+                context.transactionAuthor = nil
             }
             try scratchPad.obtainPermanentIDs(for: [object])
             return object.asUnmanaged
@@ -70,16 +71,19 @@ extension CoreDataRepository {
     public func update<Model: UnmanagedModel>(
         _ url: URL,
         with item: Model,
-        transactionAuthor _: String? = nil
+        transactionAuthor: String? = nil
     ) async -> Result<Model, CoreDataRepositoryError> {
         await context.performInScratchPad(schedule: .enqueued) { [context] scratchPad in
+            scratchPad.transactionAuthor = transactionAuthor
             let id = try scratchPad.tryObjectId(from: url)
             let object = try scratchPad.notDeletedObject(for: id)
             let repoManaged: Model.RepoManaged = try object.asRepoManaged()
             repoManaged.update(from: item)
             try scratchPad.save()
             try context.performAndWait {
+                context.transactionAuthor = transactionAuthor
                 try context.save()
+                context.transactionAuthor = nil
             }
             return repoManaged.asUnmanaged
         }
@@ -97,16 +101,19 @@ extension CoreDataRepository {
     ///
     public func delete(
         _ url: URL,
-        transactionAuthor _: String? = nil
+        transactionAuthor: String? = nil
     ) async -> Result<Void, CoreDataRepositoryError> {
         await context.performInScratchPad(schedule: .enqueued) { [context] scratchPad in
+            scratchPad.transactionAuthor = transactionAuthor
             let id = try scratchPad.tryObjectId(from: url)
             let object = try scratchPad.notDeletedObject(for: id)
             object.prepareForDeletion()
             scratchPad.delete(object)
             try scratchPad.save()
             try context.performAndWait {
+                context.transactionAuthor = transactionAuthor
                 try context.save()
+                context.transactionAuthor = nil
             }
             return ()
         }