Skip to content

Commit aa28605

Browse files
committed
feat: US-001 - Fix crypto KeyObject metadata (asymmetricKeyType, asymmetricKeyDetails)
1 parent a2cd01a commit aa28605

14 files changed

Lines changed: 1622 additions & 2137 deletions

File tree

CLAUDE.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050

5151
- use pnpm, vitest, and tsc for type checks
5252
- use turbo for builds
53+
- after changing `packages/core/isolate-runtime/src/inject/require-setup.ts` or Node bridge code that regenerates the isolate bundle, rebuild in this order: `pnpm --filter @secure-exec/nodejs build` then `pnpm --filter @secure-exec/core build`; the conformance runner executes built `dist` output, not just source files
5354
- keep timeouts under 1 minute and avoid running full test suites unless necessary
5455
- use one-line Conventional Commit messages; never add any co-authors (including agents)
5556
- never mark work complete until typechecks pass and all tests pass in the current turn; if they fail, report the failing command and first concrete error
@@ -198,6 +199,8 @@ Follow the style in `packages/secure-exec/src/index.ts`.
198199

199200
## Documentation
200201

202+
- all public-facing docs (quickstart, guides, API reference, landing page, README) must focus on the **Node.js runtime** as the primary and default experience — do not lead with WasmVM, kernel internals, or multi-runtime concepts
203+
- code examples in docs should use the `NodeRuntime` API (`runtime.run()`, `runtime.exec()`) as the default path; the kernel API (`createKernel`, `kernel.spawn()`) is for advanced multi-process use cases and should be presented as secondary
201204
- WasmVM and Python docs are experimental docs and must stay grouped under the `Experimental` section in `docs/docs.json`
202205
- docs pages that must stay current with API changes:
203206
- `docs/quickstart.mdx` — update when core setup flow changes

docs/nodejs-conformance-report.mdx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,18 @@ description: Node.js v22 test/parallel/ conformance results for the secure-exec
1212
| Node.js version | 22.14.0 |
1313
| Source | v22.14.0 (test/parallel/) |
1414
| Total tests | 3532 |
15-
| Passing (genuine) | 704 (19.9%) |
15+
| Passing (genuine) | 730 (20.7%) |
1616
| Passing (vacuous self-skip) | 34 |
17-
| Passing (total) | 738 (20.9%) |
18-
| Expected fail | 2723 |
17+
| Passing (total) | 764 (21.6%) |
18+
| Expected fail | 2697 |
1919
| Skip | 71 |
2020
| Last updated | 2026-03-25 |
2121

2222
## Failure Categories
2323

2424
| Category | Tests |
2525
| --- | --- |
26-
| implementation-gap | 1422 |
26+
| implementation-gap | 1396 |
2727
| unsupported-module | 737 |
2828
| requires-v8-flags | 239 |
2929
| requires-exec-path | 200 |
@@ -70,7 +70,7 @@ description: Node.js v22 test/parallel/ conformance results for the secure-exec
7070
| constants | 1 | 0 | 1 | 0 | 0.0% |
7171
| corepack | 1 | 0 | 1 | 0 | 0.0% |
7272
| coverage | 1 | 0 | 1 | 0 | 0.0% |
73-
| crypto | 99 | 16 (13 vacuous) | 83 | 0 | 16.2% |
73+
| crypto | 99 | 42 (13 vacuous) | 57 | 0 | 42.4% |
7474
| cwd | 3 | 0 | 3 | 0 | 0.0% |
7575
| data | 1 | 0 | 1 | 0 | 0.0% |
7676
| datetime | 1 | 0 | 1 | 0 | 0.0% |
@@ -245,11 +245,11 @@ description: Node.js v22 test/parallel/ conformance results for the secure-exec
245245
| wrap | 4 | 0 | 4 | 0 | 0.0% |
246246
| x509 | 1 | 0 | 1 | 0 | 0.0% |
247247
| zlib | 53 | 17 | 33 | 3 | 34.0% |
248-
| **Total** | **3532** | **738** | **2723** | **71** | **21.3%** |
248+
| **Total** | **3532** | **764** | **2697** | **71** | **22.1%** |
249249

250250
## Expectations Detail
251251

252-
### implementation-gap (741 entries)
252+
### implementation-gap (715 entries)
253253

254254
**Glob patterns:**
255255

@@ -260,7 +260,7 @@ description: Node.js v22 test/parallel/ conformance results for the secure-exec
260260
- `test-https-*.js` — https depends on tls — most tests fail on missing TLS fixture files or crypto API gaps
261261
- `test-http2-*.js` — http2 module bridged via kernel — most tests fail on API gaps, missing fixtures, or protocol handling
262262

263-
*735 individual tests — see expectations.json for full list.*
263+
*709 individual tests — see expectations.json for full list.*
264264

265265
### unsupported-module (190 entries)
266266

0 commit comments

Comments
 (0)