Skip to content

Commit 9d7b121

Browse files
committed
chore: update progress for US-109, US-110
1 parent 851d1b8 commit 9d7b121

2 files changed

Lines changed: 13 additions & 2 deletions

File tree

scripts/ralph/prd.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1944,7 +1944,7 @@
19441944
"Tests pass"
19451945
],
19461946
"priority": 115,
1947-
"passes": false,
1947+
"passes": true,
19481948
"notes": "LOW \u2014 found during PTY review. PTY foregroundPgid goes stale when process exits. Protected by try/catch in kernel constructor wiring but untested."
19491949
},
19501950
{
@@ -1958,7 +1958,7 @@
19581958
"Tests pass"
19591959
],
19601960
"priority": 116,
1961-
"passes": false,
1961+
"passes": true,
19621962
"notes": "LOW \u2014 depends on US-106 (echo overflow fix). Tests the specific interaction between buffer fullness and echo."
19631963
},
19641964
{

scripts/ralph/progress.txt

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1474,3 +1474,14 @@ PRD: ralph/kernel-hardening (46 stories)
14741474
- In canonical mode, chars beyond MAX_CANON are silently dropped (no EAGAIN) — only buffer-level EAGAIN applies to input/output buffers
14751475
- Echo with canonical mode: echo output is bounded by MAX_CANON (only accepted chars get echoed) + 2 bytes for CR+LF on newline flush
14761476
---
1477+
1478+
## 2026-03-18 - US-109, US-110
1479+
- US-109: Already implemented in prior iteration (commit 667669d). Verified tests pass, marked passes: true.
1480+
- US-110: Added 2 kernel-integration-level PTY echo buffer exhaustion tests through fdWrite/fdRead kernel interface
1481+
- Test 1: fill output buffer via slave write, verify fdWrite to master with echo enabled throws EAGAIN
1482+
- Test 2: drain buffer via master read, verify echo resumes (write 'B', read echo 'B' back)
1483+
- Files changed: packages/kernel/test/kernel-integration.test.ts (added MAX_PTY_BUFFER_BYTES import + 2 tests in termios section)
1484+
- **Learnings for future iterations:**
1485+
- Integration-level PTY tests use ki.fdWrite/ki.fdRead (kernel interface), not ptyManager.write/read directly
1486+
- Output buffer fills via slave write (slave→master direction); echo goes in the same direction, so echo is blocked when output buffer is full
1487+
---

0 commit comments

Comments
 (0)