Skip to content

Commit 5f829a2

Browse files
NathanFlurryclaude
andcommitted
chore: update progress for US-059
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 3e3b922 commit 5f829a2

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

progress.txt

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2745,3 +2745,13 @@ PRD: ralph/kernel-hardening (46 stories)
27452745
- ReaderResponseReceiver::new() takes Box<dyn Read + Send>, not a concrete type — need Box::new() wrapper
27462746
- SIGSEGV on cargo test exit is pre-existing (V8 global state cleanup across test suites) — all 74 tests pass before SIGSEGV
27472747
---
2748+
2749+
## 2026-03-19 - US-059
2750+
- What was implemented: Replaced direct property assignment in setup-fs-facade.ts with Object.defineProperties using getters for all 19 fs bridge functions
2751+
- Each _fs property getter now resolves globalThis._fsXxx at call time, not setup time — enabling snapshot-restored contexts to pick up replaced bridge function globals
2752+
- Files changed: packages/secure-exec-core/isolate-runtime/src/inject/setup-fs-facade.ts, packages/secure-exec-core/src/generated/isolate-runtime.ts (auto-regenerated)
2753+
- **Learnings for future iterations:**
2754+
- The getter pattern is transparent to callers — all existing fs tests pass unchanged with identical pass/fail counts
2755+
- packages/secure-exec-core/dist/ is gitignored — don't try to stage files from there
2756+
- The generated isolate-runtime.ts is auto-regenerated by `pnpm run --filter @secure-exec/core build` (specifically build:isolate-runtime)
2757+
---

scripts/ralph/prd.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1000,8 +1000,8 @@
10001000
"Tests pass"
10011001
],
10021002
"priority": 59,
1003-
"passes": false,
1004-
"notes": "Spec: docs-internal/specs/v8-context-snapshot.md Phase 1. Prerequisite for context snapshot."
1003+
"passes": true,
1004+
"notes": "Spec: docs-internal/specs/v8-context-snapshot.md Phase 1. Replaced direct property assignment with Object.defineProperties using getters for all 19 fs bridge functions. Each _fs.xxx call now resolves globalThis._fsXxx at call time, enabling snapshot restore to replace bridge globals."
10051005
},
10061006
{
10071007
"id": "US-060",

0 commit comments

Comments
 (0)