You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: scripts/ralph/prd.json
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -417,7 +417,7 @@
417
417
"pnpm --filter secure-exec exec vitest run passes"
418
418
],
419
419
"priority": 25,
420
-
"passes": false,
420
+
"passes": true,
421
421
"notes": "Cleanup story after US-023 and US-024. The regex hacks to remove/bypass: (1) transformDynamicImport in esm-utils.ts:22 — replaces import( with __dynamicImport( via regex, breaks minified code, (2) convertEsmToCjs in bridge-handlers.ts:968 — 100-line regex ESM→CJS converter, breaks on edge cases, (3) __dynamicImport shim in global-exposure.ts:337 and bridge-contract.ts:24 — no longer needed when V8 handles import() natively. The browser worker (packages/browser/src/worker.ts) may still need these hacks since it doesn't use the V8 sidecar — leave those paths intact but clearly mark them as browser-only fallbacks."
- V8's dynamic_import_callback works in BOTH CJS (execute_script) and ESM (execute_module) modes — no JS-side shim needed
817
+
- When V8's module system loads a CJS file via import(), it must be wrapped as ESM (wrapCJSForESMWithModulePath) because V8 parses all module loads as ESM
818
+
- The __dynamicImport global is still installed in V8 snapshots but never called — removing it would require a snapshot rebuild
819
+
- convertEsmToCjs is still needed in loadFileSync for require() of ESM-only packages in CJS exec mode
0 commit comments