Skip to content

Commit 306e2eb

Browse files
committed
mark more function args as const ref
1 parent 201e743 commit 306e2eb

5 files changed

Lines changed: 17 additions & 17 deletions

File tree

src/components.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,14 @@ struct declare_component_types {
2626
new (c) Component(size_hint);
2727
}, "size_hint"_a = 0,
2828
nb::call_guard<nb::gil_scoped_release>())
29-
.def(nb::init<Component>(),
29+
.def(nb::init<const Component&>(),
3030
"component"_a,
3131
nb::call_guard<nb::gil_scoped_release>())
32-
.def(nb::init<std::vector<VertT>, std::size_t>(),
32+
.def(nb::init<const std::vector<VertT>&, std::size_t>(),
3333
"vertices"_a, "size_hint"_a = 0,
3434
nb::call_guard<nb::gil_scoped_release>())
35-
.def(nb::init<std::unordered_set<
36-
VertT, reticula::hash<VertT>>, std::size_t>(),
35+
.def(nb::init<const std::unordered_set<
36+
VertT, reticula::hash<VertT>>&, std::size_t>(),
3737
"vertices"_a, "size_hint"_a = 0,
3838
nb::call_guard<nb::gil_scoped_release>())
3939
.def("insert",

src/implicit_event_graphs.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,16 @@ struct declare_implicit_event_graph_class {
2323
m, python_type_str<Net>().c_str())
2424
.def(nb::init<const Net&>(),
2525
nb::call_guard<nb::gil_scoped_release>())
26-
.def(nb::init<std::vector<EdgeT>, AdjT>(),
26+
.def(nb::init<const std::vector<EdgeT>&, AdjT>(),
2727
"events"_a, "temporal_adjacency"_a,
2828
nb::call_guard<nb::gil_scoped_release>())
2929
.def(nb::init<
30-
std::vector<EdgeT>,
31-
std::vector<typename EdgeT::VertexType>,
32-
AdjT>(),
30+
const std::vector<EdgeT>&,
31+
const std::vector<typename EdgeT::VertexType>&,
32+
const AdjT&>(),
3333
"events"_a, "verts"_a, "temporal_adjacency"_a,
3434
nb::call_guard<nb::gil_scoped_release>())
35-
.def(nb::init<reticula::network<EdgeT>, AdjT>(),
35+
.def(nb::init<const reticula::network<EdgeT>&, const AdjT&>(),
3636
"temporal_network"_a, "temporal_adjacency"_a,
3737
nb::call_guard<nb::gil_scoped_release>())
3838
.def("events_cause",

src/networks.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@ struct declare_network_class {
2424
.def(nb::init<const Net&>(),
2525
"network"_a,
2626
nb::call_guard<nb::gil_scoped_release>())
27-
.def(nb::init<std::vector<EdgeT>>(),
27+
.def(nb::init<const std::vector<EdgeT>&>(),
2828
"edges"_a,
2929
nb::call_guard<nb::gil_scoped_release>())
3030
.def(nb::init<
31-
std::vector<EdgeT>,
32-
std::vector<typename EdgeT::VertexType>>(),
31+
const std::vector<EdgeT>&,
32+
const std::vector<typename EdgeT::VertexType>&>(),
3333
"edges"_a, "verts"_a,
3434
nb::call_guard<nb::gil_scoped_release>())
3535
.def("vertices",

src/static_hyperedges.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,20 @@ template <typename VertT>
1818
struct declare_static_hyperedges {
1919
void operator()(nb::module_ &m) {
2020
define_basic_edge_concept<reticula::undirected_hyperedge<VertT>>(m)
21-
.def(nb::init<std::vector<VertT>>(),
21+
.def(nb::init<const std::vector<VertT>&>(),
2222
"verts"_a, nb::call_guard<nb::gil_scoped_release>());
2323

2424
nb::implicitly_convertible<
2525
std::vector<VertT>,
2626
reticula::undirected_hyperedge<VertT>>();
2727

2828
define_basic_edge_concept<reticula::directed_hyperedge<VertT>>(m)
29-
.def(nb::init<std::vector<VertT>, std::vector<VertT>>(),
29+
.def(nb::init<const std::vector<VertT>&, const std::vector<VertT>&>(),
3030
"tails"_a, "heads"_a,
3131
nb::call_guard<nb::gil_scoped_release>())
3232
.def("__init__", [](
3333
reticula::directed_hyperedge<VertT>* edge,
34-
std::tuple<std::vector<VertT>, std::vector<VertT>> t) {
34+
const std::tuple<std::vector<VertT>, std::vector<VertT>>& t) {
3535
new (edge) reticula::directed_hyperedge<VertT>{
3636
std::get<0>(t), std::get<1>(t)};
3737
}, "tuple"_a, nb::call_guard<nb::gil_scoped_release>())

src/temporal_clusters.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@ struct declare_temporal_cluster_types {
2020
using Cluster = reticula::temporal_cluster<EdgeT, AdjT>;
2121
nb::class_<Cluster>(
2222
m, python_type_str<Cluster>().c_str())
23-
.def(nb::init<AdjT, std::size_t>(),
23+
.def(nb::init<const AdjT&, std::size_t>(),
2424
"temporal_adjacency"_a, "size_hint"_a = 0,
2525
nb::call_guard<nb::gil_scoped_release>())
2626
.def(nb::init<const Cluster&>(),
2727
"temporal_cluester"_a,
2828
nb::call_guard<nb::gil_scoped_release>())
29-
.def(nb::init<std::vector<EdgeT>, AdjT, std::size_t>(),
29+
.def(nb::init<const std::vector<EdgeT>&, const AdjT&, std::size_t>(),
3030
"events"_a,
3131
"temporal_adjacency"_a,
3232
"size_hint"_a = 0,

0 commit comments

Comments
 (0)