Final QA (#518)

Author: gahjelle

python-pydantic/pydantic_models.py

@@ -1,7 +1,8 @@
-from typing import Self
 from datetime import date
-from uuid import UUID, uuid4
 from enum import Enum
+from typing import Self
+from uuid import UUID, uuid4
+
 from pydantic import (
     BaseModel,
     EmailStr,
@@ -19,7 +20,7 @@ class Department(Enum):
 
 
 class Employee(BaseModel):
-    employee_id: UUID = Field(default_factory=lambda: uuid4(), frozen=True)
+    employee_id: UUID = Field(default_factory=uuid4, frozen=True)
     name: str = Field(min_length=1, frozen=True)
     email: EmailStr = Field(pattern=r".+@example\.com$")
     date_of_birth: date = Field(alias="birth_date", repr=False, frozen=True)
@@ -30,10 +31,10 @@ class Employee(BaseModel):
     @field_validator("date_of_birth")
     @classmethod
     def check_valid_age(cls, date_of_birth: date) -> date:
-        date_delta = date.today() - date_of_birth
-        age = date_delta.days / 365
+        today = date.today()
+        eighteen_years_ago = date(today.year - 18, today.month, today.day)
 
-        if age < 18:
+        if date_of_birth > eighteen_years_ago:
             raise ValueError("Employees must be at least 18 years old.")
 
         return date_of_birth

python-pydantic/settings_management.py

@@ -1,4 +1,4 @@
-from pydantic import HttpUrl, Field
+from pydantic import Field, HttpUrl
 from pydantic_settings import BaseSettings, SettingsConfigDict
 
 

python-pydantic/validate_functions.py

@@ -1,6 +1,7 @@
 import time
 from typing import Annotated
-from pydantic import PositiveFloat, validate_call, Field, EmailStr
+
+from pydantic import EmailStr, Field, PositiveFloat, validate_call
 
 
 @validate_call