Fix Firefox zoom issue for non-publisher font

JayPanoz · JayPanoz · commit 3f828eb73c76 · 2025-04-11T15:55:14.000+02:00
Zoom implementation of firefox breaks completely when an element has a font-family set, including value inherit. This means we have to use revert, which will inherit if it is inheritable.
diff --git a/css/dist/ReadiumCSS-after.css b/css/dist/ReadiumCSS-after.css
@@ -1,5 +1,5 @@
 /*
- * Readium CSS (v. 2.0.0-beta.8)
+ * Readium CSS (v. 2.0.0-beta.9)
  * Developers: Jiminy Panoz 
  * Copyright (c) 2017. Readium Foundation. All rights reserved.
  * Use of this source code is governed by a BSD-style license which is detailed in the
@@ -357,7 +357,7 @@ body{
 }
 
 :root[style*="readium-font-on"][style*="--USER__fontFamily"] *:not(code):not(var):not(kbd):not(samp){
-  font-family:inherit !important;
+  font-family:revert !important;
 }
 
 :root[style*="readium-font-on"][style*="AccessibleDfA"]{
diff --git a/css/dist/ReadiumCSS-before.css b/css/dist/ReadiumCSS-before.css
@@ -1,5 +1,5 @@
 /*
- * Readium CSS (v. 2.0.0-beta.8)
+ * Readium CSS (v. 2.0.0-beta.9)
  * Developers: Jiminy Panoz 
  * Copyright (c) 2017. Readium Foundation. All rights reserved.
  * Use of this source code is governed by a BSD-style license which is detailed in the
diff --git a/css/dist/ReadiumCSS-default.css b/css/dist/ReadiumCSS-default.css
@@ -1,5 +1,5 @@
 /*
- * Readium CSS (v. 2.0.0-beta.8)
+ * Readium CSS (v. 2.0.0-beta.9)
  * Developers: Jiminy Panoz 
  * Copyright (c) 2017. Readium Foundation. All rights reserved.
  * Use of this source code is governed by a BSD-style license which is detailed in the
diff --git a/css/dist/cjk-horizontal/ReadiumCSS-after.css b/css/dist/cjk-horizontal/ReadiumCSS-after.css
@@ -1,5 +1,5 @@
 /*
- * Readium CSS (v. 2.0.0-beta.8)
+ * Readium CSS (v. 2.0.0-beta.9)
  * Developers: Jiminy Panoz 
  * Copyright (c) 2017. Readium Foundation. All rights reserved.
  * Use of this source code is governed by a BSD-style license which is detailed in the
@@ -323,7 +323,7 @@ body{
 }
 
 :root[style*="readium-font-on"][style*="--USER__fontFamily"] *:not(code):not(var):not(kbd):not(samp){
-  font-family:inherit !important;
+  font-family:revert !important;
 }
 
 :root[style*="--USER__fontSize"] body{
diff --git a/css/dist/cjk-horizontal/ReadiumCSS-before.css b/css/dist/cjk-horizontal/ReadiumCSS-before.css
@@ -1,5 +1,5 @@
 /*
- * Readium CSS (v. 2.0.0-beta.8)
+ * Readium CSS (v. 2.0.0-beta.9)
  * Developers: Jiminy Panoz 
  * Copyright (c) 2017. Readium Foundation. All rights reserved.
  * Use of this source code is governed by a BSD-style license which is detailed in the
diff --git a/css/dist/cjk-horizontal/ReadiumCSS-default.css b/css/dist/cjk-horizontal/ReadiumCSS-default.css
@@ -1,5 +1,5 @@
 /*
- * Readium CSS (v. 2.0.0-beta.8)
+ * Readium CSS (v. 2.0.0-beta.9)
  * Developers: Jiminy Panoz 
  * Copyright (c) 2017. Readium Foundation. All rights reserved.
  * Use of this source code is governed by a BSD-style license which is detailed in the
diff --git a/css/dist/cjk-vertical/ReadiumCSS-after.css b/css/dist/cjk-vertical/ReadiumCSS-after.css
@@ -1,5 +1,5 @@
 /*
- * Readium CSS (v. 2.0.0-beta.8)
+ * Readium CSS (v. 2.0.0-beta.9)
  * Developers: Jiminy Panoz 
  * Copyright (c) 2017. Readium Foundation. All rights reserved.
  * Use of this source code is governed by a BSD-style license which is detailed in the
@@ -311,7 +311,7 @@ body{
 }
 
 :root[style*="readium-font-on"][style*="--USER__fontFamily"] *:not(code):not(var):not(kbd):not(samp){
-  font-family:inherit !important;
+  font-family:revert !important;
 }
 
 :root[style*="--USER__fontSize"] body{
diff --git a/css/dist/cjk-vertical/ReadiumCSS-before.css b/css/dist/cjk-vertical/ReadiumCSS-before.css
@@ -1,5 +1,5 @@
 /*
- * Readium CSS (v. 2.0.0-beta.8)
+ * Readium CSS (v. 2.0.0-beta.9)
  * Developers: Jiminy Panoz 
  * Copyright (c) 2017. Readium Foundation. All rights reserved.
  * Use of this source code is governed by a BSD-style license which is detailed in the
diff --git a/css/dist/cjk-vertical/ReadiumCSS-default.css b/css/dist/cjk-vertical/ReadiumCSS-default.css
@@ -1,5 +1,5 @@
 /*
- * Readium CSS (v. 2.0.0-beta.8)
+ * Readium CSS (v. 2.0.0-beta.9)
  * Developers: Jiminy Panoz 
  * Copyright (c) 2017. Readium Foundation. All rights reserved.
  * Use of this source code is governed by a BSD-style license which is detailed in the
diff --git a/css/dist/rtl/ReadiumCSS-after.css b/css/dist/rtl/ReadiumCSS-after.css
@@ -1,5 +1,5 @@
 /*
- * Readium CSS (v. 2.0.0-beta.8)
+ * Readium CSS (v. 2.0.0-beta.9)
  * Developers: Jiminy Panoz 
  * Copyright (c) 2017. Readium Foundation. All rights reserved.
  * Use of this source code is governed by a BSD-style license which is detailed in the
@@ -337,7 +337,7 @@ body{
 }
 
 :root[style*="readium-font-on"][style*="--USER__fontFamily"] *:not(code):not(var):not(kbd):not(samp){
-  font-family:inherit !important;
+  font-family:revert !important;
 }
 
 :root[style*="--USER__fontSize"] body{
diff --git a/css/dist/rtl/ReadiumCSS-before.css b/css/dist/rtl/ReadiumCSS-before.css
@@ -1,5 +1,5 @@
 /*
- * Readium CSS (v. 2.0.0-beta.8)
+ * Readium CSS (v. 2.0.0-beta.9)
  * Developers: Jiminy Panoz 
  * Copyright (c) 2017. Readium Foundation. All rights reserved.
  * Use of this source code is governed by a BSD-style license which is detailed in the
diff --git a/css/dist/rtl/ReadiumCSS-default.css b/css/dist/rtl/ReadiumCSS-default.css
@@ -1,5 +1,5 @@
 /*
- * Readium CSS (v. 2.0.0-beta.8)
+ * Readium CSS (v. 2.0.0-beta.9)
  * Developers: Jiminy Panoz 
  * Copyright (c) 2017. Readium Foundation. All rights reserved.
  * Use of this source code is governed by a BSD-style license which is detailed in the
diff --git a/css/src/modules/user-settings-submodules/ReadiumCSS-fontFamily_pref.css b/css/src/modules/user-settings-submodules/ReadiumCSS-fontFamily_pref.css
@@ -10,6 +10,8 @@
   font-family: var(--USER__fontFamily) !important;
 }
 
+/* We are using revert instead of inherit as Firefox zoom implementation will break 
+   as soon as font-family is set to an element, including value inherit */
 :root:--font-override[style*="--USER__fontFamily"] *:not(code):not(var):not(kbd):not(samp) {
-  font-family: inherit !important;
+  font-family: revert !important;
 }
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@readium/css",
   "description": "A set of reference stylesheets for EPUB Reading Systems",
-  "version": "2.0.0-beta.8",
+  "version": "2.0.0-beta.9",
   "homepage": "https://github.com/readium/readium-css",
   "license": "BSD-3-Clause",
   "keywords": [

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/*`
`2`		`- * Readium CSS (v. 2.0.0-beta.8)`
	`2`	`+ * Readium CSS (v. 2.0.0-beta.9)`
`3`	`3`	`* Developers: Jiminy Panoz`
`4`	`4`	`* Copyright (c) 2017. Readium Foundation. All rights reserved.`
`5`	`5`	`* Use of this source code is governed by a BSD-style license which is detailed in the`
`@@ -357,7 +357,7 @@ body{`
`357`	`357`	`}`
`358`	`358`
`359`	`359`	`:root[style="readium-font-on"][style="--USER__fontFamily"] *:not(code):not(var):not(kbd):not(samp){`
`360`		`- font-family:inherit !important;`
	`360`	`+ font-family:revert !important;`
`361`	`361`	`}`
`362`	`362`
`363`	`363`	`:root[style="readium-font-on"][style="AccessibleDfA"]{`