Improve risky tests to contain rudimentary assertions

Author: clue

tests/IntegrationTest.php

@@ -163,6 +163,9 @@ public function testSelfSignedResolvesIfVerificationIsDisabled()
 
         $conn = Block\await($connector->connect('tls://self-signed.badssl.com:443'), $loop, self::TIMEOUT);
         $conn->close();
+
+        // if we reach this, then everything is good
+        $this->assertNull(null);
     }
 
     public function testCancelPendingConnection()

tests/SecureIntegrationTest.php

@@ -51,6 +51,9 @@ public function testConnectToServer()
         /* @var $client ConnectionInterface */
 
         $client->close();
+
+        // if we reach this, then everything is good
+        $this->assertNull(null);
     }
 
     public function testConnectToServerEmitsConnection()

tests/ServerTest.php

@@ -13,11 +13,13 @@ class ServerTest extends TestCase
 {
     const TIMEOUT = 0.1;
 
-    public function testCreateServer()
+    public function testCreateServerWithZeroPortAssignsRandomPort()
     {
         $loop = Factory::create();
 
         $server = new Server(0, $loop);
+        $this->assertNotEquals(0, $server->getAddress());
+        $server->close();
     }
 
     /**
@@ -80,7 +82,7 @@ public function testDoesNotEmitConnectionForNewConnectionToPausedServer()
 
         $server = new Server(0, $loop);
         $server->pause();
-
+        $server->on('connection', $this->expectCallableNever());
 
         $client = stream_socket_client($server->getAddress());
 

tests/TcpConnectorTest.php

@@ -174,20 +174,6 @@ public function connectionToInvalidSchemeShouldFailImmediately()
         );
     }
 
-    /** @test */
-    public function connectionWithInvalidContextShouldFailImmediately()
-    {
-        $this->markTestIncomplete();
-
-        $loop = $this->getMockBuilder('React\EventLoop\LoopInterface')->getMock();
-
-        $connector = new TcpConnector($loop, array('bindto' => 'invalid.invalid:123456'));
-        $connector->connect('127.0.0.1:80')->then(
-            $this->expectCallableNever(),
-            $this->expectCallableOnce()
-        );
-    }
-
     /** @test */
     public function cancellingConnectionShouldRejectPromise()
     {

tests/TcpServerTest.php

@@ -107,12 +107,18 @@ public function testLoopWillEndWhenServerIsClosed()
         $this->server = null;
 
         $this->loop->run();
+
+        // if we reach this, then everything is good
+        $this->assertNull(null);
     }
 
     public function testCloseTwiceIsNoOp()
     {
         $this->server->close();
         $this->server->close();
+
+        // if we reach this, then everything is good
+        $this->assertNull(null);
     }
 
     public function testGetAddressAfterCloseReturnsNull()
@@ -136,6 +142,9 @@ public function testLoopWillEndWhenServerIsClosedAfterSingleConnection()
         });
 
         $this->loop->run();
+
+        // if we reach this, then everything is good
+        $this->assertNull(null);
     }
 
     public function testDataWillBeEmittedInMultipleChunksWhenClientSendsExcessiveAmounts()

tests/UnixServerTest.php

@@ -100,12 +100,18 @@ public function testLoopWillEndWhenServerIsClosed()
         $this->server = null;
 
         $this->loop->run();
+
+        // if we reach this, then everything is good
+        $this->assertNull(null);
     }
 
     public function testCloseTwiceIsNoOp()
     {
         $this->server->close();
         $this->server->close();
+
+        // if we reach this, then everything is good
+        $this->assertNull(null);
     }
 
     public function testGetAddressAfterCloseReturnsNull()
@@ -129,6 +135,9 @@ public function testLoopWillEndWhenServerIsClosedAfterSingleConnection()
         });
 
         $this->loop->run();
+
+        // if we reach this, then everything is good
+        $this->assertNull(null);
     }
 
     public function testDataWillBeEmittedInMultipleChunksWhenClientSendsExcessiveAmounts()
@@ -164,9 +173,6 @@ public function testDataWillBeEmittedInMultipleChunksWhenClientSendsExcessiveAmo
         $this->assertEquals($bytes, $received);
     }
 
-    /**
-     * @covers React\EventLoop\StreamSelectLoop::tick
-     */
     public function testConnectionDoesNotEndWhenClientDoesNotClose()
     {
         $client = stream_socket_client($this->uds);
@@ -181,7 +187,6 @@ public function testConnectionDoesNotEndWhenClientDoesNotClose()
     }
 
     /**
-     * @covers React\EventLoop\StreamSelectLoop::tick
      * @covers React\Socket\Connection::end
      */
     public function testConnectionDoesEndWhenClientCloses()