Fix bug in When::any() not correctly unwrapping to a single result value

Author: jsor

CHANGELOG.md

@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+
+* 1.0.2 (xxxx-xx-xx)
+
+  * Fix bug in When::any() not correctly unwrapping to a single result value
+
 * 1.0.1 (2012-11-13)
 
   * Prevent deep recursion which was reaching `xdebug.max_nesting_level` default of 100

src/React/Promise/When.php

@@ -28,7 +28,7 @@ public static function all($promisesOrValues, $fulfilledHandler = null, $errorHa
     public static function any($promisesOrValues, $fulfilledHandler = null, $errorHandler = null, $progressHandler = null)
     {
         $unwrapSingleResult = function ($val) use ($fulfilledHandler) {
-            $val = isset($val[0]) ? $val[0] : null;
+            $val = array_shift($val);
 
             return $fulfilledHandler ? $fulfilledHandler($val) : $val;
         };

tests/React/Promise/WhenAnyTest.php

@@ -110,4 +110,25 @@ public function shouldResolveToNullArrayWhenInputPromiseDoesNotResolveToArray()
             $mock
         );
     }
+
+    /** @test */
+    public function shouldNotRelyOnArryIndexesWhenUnwrappingToASingleResolutionValue()
+    {
+        $mock = $this->createCallableMock();
+        $mock
+            ->expects($this->once())
+            ->method('__invoke')
+            ->with($this->identicalTo(2));
+
+        $d1 = new Deferred();
+        $d2 = new Deferred();
+
+        When::any(
+            array('abc' => $d1->promise(), 1 => $d2->promise()),
+            $mock
+        );
+
+        $d2->resolve(2);
+        $d1->resolve(1);
+    }
 }