Skip to content

Commit 8967d23

Browse files
committed
Add missing Throwable parameter type-declarations to rejection functions
1 parent f12d524 commit 8967d23

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/Deferred.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public function resolve($value = null)
3636
\call_user_func($this->resolveCallback, $value);
3737
}
3838

39-
public function reject($reason)
39+
public function reject(\Throwable $reason)
4040
{
4141
$this->promise();
4242

src/Promise.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ private function resolve($value = null)
129129
$this->settle(resolve($value));
130130
}
131131

132-
private function reject($reason)
132+
private function reject(\Throwable $reason)
133133
{
134134
if (null !== $this->result) {
135135
return;
@@ -198,7 +198,7 @@ private function call(callable $callback)
198198
function ($value = null) {
199199
$this->resolve($value);
200200
},
201-
function ($reason) {
201+
function (\Throwable $reason) {
202202
$this->reject($reason);
203203
}
204204
);

src/RejectedPromise.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public function otherwise(callable $onRejected)
6262

6363
public function always(callable $onFulfilledOrRejected)
6464
{
65-
return $this->then(null, function ($reason) use ($onFulfilledOrRejected) {
65+
return $this->then(null, function (\Throwable $reason) use ($onFulfilledOrRejected) {
6666
return resolve($onFulfilledOrRejected())->then(function () use ($reason) {
6767
return new RejectedPromise($reason);
6868
});

src/functions.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ function some(array $promisesOrValues, $howMany)
188188
}
189189
};
190190

191-
$rejecter = function ($reason) use ($i, &$reasons, &$toReject, $toResolve, $reject) {
191+
$rejecter = function (\Throwable $reason) use ($i, &$reasons, &$toReject, $toResolve, $reject) {
192192
if ($toResolve < 1 || $toReject < 1) {
193193
return;
194194
}

0 commit comments

Comments
 (0)