Skip to content

Commit b9ed1e6

Browse files
committed
Tag Browser as final to discourage inheriting from it
1 parent 4fbbeb0 commit b9ed1e6

2 files changed

Lines changed: 5 additions & 0 deletions

File tree

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1866,6 +1866,8 @@ $connector = new React\Socket\Connector($loop, array(
18661866
$browser = new React\Http\Browser($loop, $connector);
18671867
```
18681868

1869+
> Note that the browser class is final and shouldn't be extended, it is likely to be marked final in a future release.
1870+
18691871
#### get()
18701872

18711873
The `get(string $url, array $headers = array()): PromiseInterface<ResponseInterface>` method can be used to

src/Browser.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@
1313
use React\Socket\ConnectorInterface;
1414
use React\Stream\ReadableStreamInterface;
1515

16+
/**
17+
* @final This class is final and shouldn't be extended as it is likely to be marked final in a future relase.
18+
*/
1619
class Browser
1720
{
1821
private $transaction;

0 commit comments

Comments
 (0)