Skip to content

Commit f11de88

Browse files
committed
Update SocketClient to v0.7
1 parent 7bc10a6 commit f11de88

5 files changed

Lines changed: 12 additions & 16 deletions

File tree

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"require": {
77
"php": ">=5.4.0",
88
"guzzlehttp/psr7": "^1.0",
9-
"react/socket-client": "^0.6",
9+
"react/socket-client": "^0.7",
1010
"react/dns": "0.4.*",
1111
"react/event-loop": "0.4.*",
1212
"react/stream": "0.4.*",

src/Client.php

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,24 +7,16 @@
77
class Client
88
{
99
private $connector;
10-
private $secureConnector;
1110

12-
public function __construct(ConnectorInterface $connector, ConnectorInterface $secureConnector)
11+
public function __construct(ConnectorInterface $connector)
1312
{
1413
$this->connector = $connector;
15-
$this->secureConnector = $secureConnector;
1614
}
1715

1816
public function request($method, $url, array $headers = [], $protocolVersion = '1.0')
1917
{
2018
$requestData = new RequestData($method, $url, $headers, $protocolVersion);
21-
$connector = $this->getConnectorForScheme($requestData->getScheme());
2219

23-
return new Request($connector, $requestData);
24-
}
25-
26-
private function getConnectorForScheme($scheme)
27-
{
28-
return ('https' === $scheme) ? $this->secureConnector : $this->connector;
20+
return new Request($this->connector, $requestData);
2921
}
3022
}

src/Factory.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55
use React\EventLoop\LoopInterface;
66
use React\Dns\Resolver\Resolver;
77
use React\SocketClient\Connector;
8-
use React\SocketClient\SecureConnector;
98

109
class Factory
1110
{
1211
public function create(LoopInterface $loop, Resolver $resolver)
1312
{
14-
$connector = new Connector($loop, $resolver);
15-
$secureConnector = new SecureConnector($connector, $loop);
13+
$connector = new Connector($loop, array(
14+
'dns' => $resolver
15+
));
1616

17-
return new Client($connector, $secureConnector);
17+
return new Client($connector);
1818
}
1919
}

src/Request.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,10 @@ protected function connect()
230230
$host = $this->requestData->getHost();
231231
$port = $this->requestData->getPort();
232232

233+
if ($this->requestData->getScheme() === 'https') {
234+
$host = 'tls://' . $host;
235+
}
236+
233237
return $this->connector
234238
->connect($host . ':' . $port);
235239
}

tests/RequestTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class RequestTest extends TestCase
1717

1818
public function setUp()
1919
{
20-
$this->stream = $this->getMockBuilder('React\Stream\Stream')
20+
$this->stream = $this->getMockBuilder('React\SocketClient\StreamConnection')
2121
->disableOriginalConstructor()
2222
->getMock();
2323

0 commit comments

Comments
 (0)