Limit cache size to 256 results by default

clue · clue · commit 9b52f6cbe8f8 · 2019-07-06T15:42:36.000+02:00
diff --git a/src/Resolver/Factory.php b/src/Resolver/Factory.php
@@ -26,8 +26,9 @@ public function create($nameserver, LoopInterface $loop)
 
     public function createCached($nameserver, LoopInterface $loop, CacheInterface $cache = null)
     {
+        // default to keeping maximum of 256 responses in cache unless explicitly given
         if (!($cache instanceof CacheInterface)) {
-            $cache = new ArrayCache();
+            $cache = new ArrayCache(256);
         }
 
         $nameserver = $this->addPortToServerIfMissing($nameserver);

Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,9 @@ public function create($nameserver, LoopInterface $loop)`
`26`	`26`
`27`	`27`	`public function createCached($nameserver, LoopInterface $loop, CacheInterface $cache = null)`
`28`	`28`	`{`
	`29`	`+ // default to keeping maximum of 256 responses in cache unless explicitly given`
`29`	`30`	`if (!($cache instanceof CacheInterface)) {`
`30`		`- $cache = new ArrayCache();`
	`31`	`+ $cache = new ArrayCache(256);`
`31`	`32`	`}`
`32`	`33`
`33`	`34`	`$nameserver = $this->addPortToServerIfMissing($nameserver);`