Merge pull request #117 from reactdeveloperske/revert-107-feature/footer-section

Revert "[feature] create footer section"

Author: bmwasonga

e2e/footer.spec.ts

@@ -8,22 +8,19 @@ test.describe('Test Hero Header Navigation Links', () => {
   test('About us link should navigate to about us section', async ({
     page,
   }) => {
-    const headerLocator = page.locator('header');
-    await headerLocator.getByRole('link', { name: 'About us' }).click();
+    await page.getByRole('link', { name: 'About us' }).click();
     await expect(page).toHaveURL('/#about-us');
   });
 
   test('Events link should navigate to Events section', async ({ page }) => {
-    const headerLocator = page.locator('header');
-    await headerLocator.getByRole('link', { name: 'Events' }).click();
+    await page.getByRole('link', { name: 'Events' }).click();
     await expect(page).toHaveURL('/#events');
   });
 
   test('Contact link should navigate to Contact Us section', async ({
     page,
   }) => {
-    const headerLocator = page.locator('header');
-    await headerLocator.getByRole('link', { name: 'Contact' }).click();
+    await page.getByRole('link', { name: 'Contact' }).click();
     await expect(page).toHaveURL('/#contact-us');
   });
 
@@ -34,10 +31,7 @@ test.describe('Test Hero Header Navigation Links', () => {
     const [newPage] = await Promise.all([
       context.waitForEvent('page'),
       page.waitForLoadState(),
-      page
-        .locator('header')
-        .getByRole('link', { name: 'Join Community' })
-        .click(),
+      page.getByRole('link', { name: 'Join Community' }).click(),
     ]);
     await expect(newPage).toHaveURL(
       new RegExp(
@@ -53,10 +47,7 @@ test.describe('Test Hero Header Navigation Links', () => {
     const [newPage] = await Promise.all([
       context.waitForEvent('page'),
       page.waitForLoadState(),
-      page
-        .locator('header')
-        .getByRole('link', { name: 'Join ReactDevsKe' })
-        .click(),
+      page.getByRole('link', { name: 'Join ReactDevsKe' }).click(),
     ]);
     await expect(newPage).toHaveURL(
       new RegExp(

e2e/hero-header.spec.ts

@@ -20,8 +20,8 @@ export default function HeroHeader() {
   if (!screenWidth) return null;
 
   return (
-    <header id="hero" className="pt-2">
+    <div id="hero" className="pt-2">
       {screenWidth < breakpoint ? <MobileHero /> : <DesktopHero />}
-    </header>
+    </div>
   );
 }

public/img/love-icon.svg

@@ -8,7 +8,7 @@ import LinkButton from '../LinkButton/LinkButton';
 export default function Navbar() {
   return (
     <>
-      <div className="lg:pl-[49px] w-full bg-transparent">
+      <header className="lg:pl-[49px] w-full bg-transparent">
         <nav className="nav py-4 pl-5 flex flex-col md:flex-row justify-around items-center">
           <div>
             <Link href={HOME}>
@@ -41,7 +41,7 @@ export default function Navbar() {
             </LinkButton>
           </div>
         </nav>
-      </div>
+      </header>
     </>
   );
 }

src/components/Footer/Footer.tsx

@@ -4,7 +4,6 @@ import ContactUs from '../components/ContactUs';
 import Events from '../components/Events/Events';
 import MissionPillars from '../components/MissionPillars/MissionPillars';
 import HeroHeader from '../components/HeroHeader';
-import Footer from '../components/Footer';
 
 export default function Home() {
   return (
@@ -30,7 +29,6 @@ export default function Home() {
         <MissionPillars />
         <Events />
         <ContactUs />
-        <Footer />
       </main>
     </div>
   );