Skip to content

Commit 21651ec

Browse files
authored
Merge pull request #70 from orama254/develop
backlog task: add eslint and prettier to the project
2 parents 62e270f + 9f20a3a commit 21651ec

37 files changed

Lines changed: 477 additions & 245 deletions

.eslintrc.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"extends": ["next", "next/core-web-vitals", "prettier", "eslint:recommended"],
3+
"globals": {
4+
"React": "readonly"
5+
},
6+
"rules": {}
7+
}

.github/ISSUE_TEMPLATE/feature.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ body:
1111
- type: textarea
1212
attributes:
1313
label: Describe your issue
14-
description: Describe the new feature you want to add
14+
description: Describe the new feature you want to add

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ yarn-error.log*
3535
yarn.lock
3636

3737
#eslint
38-
.eslintrc.json
3938
/test-results/
4039
/playwright-report/
4140
/playwright/.cache/

.prettierignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
.yarn
2+
.next
3+
dist
4+
node_modules

.prettierrc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"trailingComma": "es5",
3+
"tabWidth": 2,
4+
"semi": true,
5+
"singleQuote": true
6+
}

CODE_OF_CONDUCT.md

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,22 +14,22 @@ appearance, race, religion, or sexual identity and orientation.
1414
Examples of behavior that contributes to creating a positive environment
1515
include:
1616

17-
* Using welcoming and inclusive language
18-
* Being respectful of differing viewpoints and experiences
19-
* Gracefully accepting constructive criticism
20-
* Focusing on what is best for the community
21-
* Showing empathy towards other community members
17+
- Using welcoming and inclusive language
18+
- Being respectful of differing viewpoints and experiences
19+
- Gracefully accepting constructive criticism
20+
- Focusing on what is best for the community
21+
- Showing empathy towards other community members
2222

2323
Examples of unacceptable behavior by participants include:
2424

25-
* The use of sexualized language or imagery and unwelcome sexual attention or
26-
advances
27-
* Trolling, insulting/derogatory comments, and personal or political attacks
28-
* Public or private harassment
29-
* Publishing others' private information, such as a physical or electronic
30-
address, without explicit permission
31-
* Other conduct which could reasonably be considered inappropriate in a
32-
professional setting
25+
- The use of sexualized language or imagery and unwelcome sexual attention or
26+
advances
27+
- Trolling, insulting/derogatory comments, and personal or political attacks
28+
- Public or private harassment
29+
- Publishing others' private information, such as a physical or electronic
30+
address, without explicit permission
31+
- Other conduct which could reasonably be considered inappropriate in a
32+
professional setting
3333

3434
## Our Responsibilities
3535

CONTRIBUTING.md

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -8,28 +8,27 @@ Please note we have a [code of conduct](https://github.com/reactdeveloperske/rea
88

99
- Create a [new issue](https://github.com/reactdeveloperske/reactdevske-website/issues)
1010
- Comment on the issue (if you'd like to be assigned to it) - that way the issue can be assigned to you.
11-
11+
1212
### Open issues
13+
1314
- Go to [open issues](https://github.com/reactdeveloperske/reactdevske-website/issues)
1415
- select an issue of your choice that is `open` or `need help` or is `up-for-grabs` and is not assigned.
1516
- Comment on the issue (if you'd like to be assigned to it) - that way the issue can be assigned to you.
16-
1717

1818
### Fork the repository (repo)
1919

2020
- If you're not sure, here's how to [fork the repo](https://help.github.com/en/articles/fork-a-repo)
2121

22-
23-
### Set up your local environment (optional)
22+
### Set up your local environment (optional)
2423

2524
If you're ready to contribute and create your PR, it will help to set up a local environment so you can see your changes.
2625

27-
1. Set up your development environment
28-
- install your favorite text editor/IDE
29-
- install [Nodejs](nodejs.org)
30-
31-
32-
<br>
26+
1. Set up your development environment
27+
28+
- install your favorite text editor/IDE
29+
- install [Nodejs](nodejs.org)
30+
31+
<br>
3332

3433
2. Clone your fork
3534

@@ -45,7 +44,6 @@ If you've already forked the repo, you'll want to ensure your fork is configured
4544

4645
To [configure your fork](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/configuring-a-remote-for-a-fork):
4746

48-
4947
```
5048
$ git remote add upstream https://github.com/reactdeveloperske/reactdevske-website.git
5149
```
@@ -60,21 +58,21 @@ $ git merge upstream/develop
6058

6159
3. Install dependencies
6260

63-
```
64-
$ yarn install
65-
```
61+
```
62+
$ yarn install
63+
```
64+
6665
or
6766

6867
```
6968
$ npm install
7069
```
71-
<br>
72-
73-
### Make awesome changes!
7470

7571
<br>
7672

73+
### Make awesome changes!
7774

75+
<br>
7876

7977
1. Create new branch for your changes
8078

@@ -87,14 +85,17 @@ $ git checkout -b new_branch_name
8785
```
8886
$ yarn run dev
8987
```
90-
or
88+
89+
or
90+
9191
```
9292
npm run dev
9393
```
9494

9595
<br>
9696

97-
### Start developing!
97+
### Start developing!
98+
9899
<br>
99100

100101
- Open this directory in your favorite text editor / IDE, and see your changes live by visiting `localhost:3000` from your browser
@@ -117,4 +118,3 @@ $ git push
117118
- After your changes are commited to your GitHub fork, submit a pull request (PR) to the `develop` branch of the `reactdeveloperske/reactdevske-website` repo
118119
- In your PR description, reference the issue it resolves (see [linking a pull request to an issue using a keyword](https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
119120
- ex. `Updates out of date content [Fixes #1234]`
120-

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,10 @@
55

66
This is the repo for the showcase website of the React Developer Community in Kenya
77

8-
98
Check out the live version [HERE](https://reactdevske.vercel.app/)
109

1110
## Contributing to the project
1211

13-
1412
Contributions are always welcome!
1513

1614
See [`contributing.md`](https://github.com/reactdeveloperske/reactdevske-website/blob/main/CONTRIBUTING.md) for ways to get started.

e2e/default.spec.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
const { test, expect } = require('@playwright/test');
33

44
test.beforeEach(async ({ page }) => {
5-
await page.goto('http://localhost:3000');
6-
});
5+
await page.goto('http://localhost:3000');
6+
});
77

88
test.describe('Basic test', () => {
9-
test('should show the title', async ({ page }) => {
10-
const title = page.locator('title');
11-
await expect(title).toHaveText('Reactjs Developer Community in Kenya');
12-
});
13-
});
9+
test('should show the title', async ({ page }) => {
10+
const title = page.locator('title');
11+
await expect(title).toHaveText('Reactjs Developer Community in Kenya');
12+
});
13+
});

next.config.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@ const nextConfig = {
33
reactStrictMode: true,
44
pageExtensions: ['page.jsx', 'api.js'],
55
eslint: {
6-
dirs: ['src','e2e'],
6+
dirs: ['src', 'e2e'],
77
},
8-
images:{
9-
domains:['bit.ly']
10-
}
11-
}
8+
images: {
9+
domains: ['bit.ly'],
10+
},
11+
};
1212

13-
module.exports = nextConfig
13+
module.exports = nextConfig;

0 commit comments

Comments
 (0)