Skip to content

Commit a1ba365

Browse files
committed
refactoring
1 parent 3611471 commit a1ba365

11 files changed

Lines changed: 25 additions & 10 deletions

File tree

jcp/src/main/java/com/igormaznitsa/jcp/context/PreprocessorContext.java

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,14 @@ private static Charset decodeCharset(final String charsetName) {
262262
}
263263
}
264264

265+
/**
266+
* Find all files which have been used during preprocess, it includes configs, source files, copied files,
267+
* generated files, included files and binary files used by functions. Excluded files are not added if
268+
* they are not processed by included files.
269+
*
270+
* @return set of all input files, must not be null
271+
* @since 7.0.3
272+
*/
265273
public Set<File> findAllInputFiles() {
266274
final Set<File> result = new HashSet<>();
267275
result.addAll(this.configFiles);
@@ -275,7 +283,13 @@ public Set<File> findAllInputFiles() {
275283
return result;
276284
}
277285

278-
public Set<File> findAllGeneratedFiles() {
286+
/**
287+
* Find all files which have been produced during preprocess, it includes also copied an generated files.
288+
*
289+
* @return set of all produced files, must not be null
290+
* @since 7.0.3
291+
*/
292+
public Set<File> findAllProducedFiles() {
279293
return this.preprocessedResources.stream()
280294
.flatMap(x -> x.getGeneratedResources().stream())
281295
.collect(Collectors.toSet());

jcp/src/main/java/com/igormaznitsa/jcp/expression/functions/FunctionEVALFILE.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public Value executeStr(final PreprocessorContext context, final Value strFilePa
110110
.ifPresent(f -> {
111111
f.getIncludedSources().add(fileToEvaluate);
112112
f.getIncludedSources().addAll(evalContext.findAllInputFiles());
113-
f.getGeneratedResources().addAll(evalContext.findAllGeneratedFiles());
113+
f.getGeneratedResources().addAll(evalContext.findAllProducedFiles());
114114
});
115115

116116
final StringWriter strWriter = new StringWriter(1024);

jcp/src/main/java/com/igormaznitsa/jcp/gradle/JcpTask.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ public void warning(final String message) {
427427
preprocessor.execute();
428428

429429
final Collection<File> foundAllGeneratedFiles =
430-
preprocessor.getContext().findAllGeneratedFiles();
430+
preprocessor.getContext().findAllProducedFiles();
431431
final Collection<File> foundAllInputFiles = preprocessor.getContext().findAllInputFiles();
432432

433433
this.outcomingFilesIterator.set(foundAllGeneratedFiles);

jcp/src/main/java/com/igormaznitsa/jcp/utils/PreprocessorUtils.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ private PreprocessorUtils() {
6666
* @param context preprocessor context, must not be null
6767
* @return found FileInfoContainr or empty optional
6868
* @see FileInfoContainer
69+
* @since 7.0.3
6970
*/
7071
public static Optional<FileInfoContainer> findFirstActiveFileContainer(
7172
final PreprocessorContext context

jcp/src/test/java/com/igormaznitsa/jcp/usecases/BinFileTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public void check(final PreprocessorContext context, final JcpPreprocessor.Stati
4141
assertEquals(1, stat.getPreprocessed());
4242
assertEquals(0, stat.getCopied());
4343
assertEquals(2, context.findAllInputFiles().size());
44-
assertEquals(1, context.findAllGeneratedFiles().size());
44+
assertEquals(1, context.findAllProducedFiles().size());
4545
}
4646

4747
}

jcp/src/test/java/com/igormaznitsa/jcp/usecases/EvalFileTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public void check(PreprocessorContext context, JcpPreprocessor.Statistics stat)
3939
assertEquals(1, stat.getPreprocessed());
4040
assertEquals(0, stat.getCopied());
4141
assertEquals(3, context.findAllInputFiles().size());
42-
assertEquals(2, context.findAllGeneratedFiles().size());
42+
assertEquals(2, context.findAllProducedFiles().size());
4343
}
4444

4545
}

jcp/src/test/java/com/igormaznitsa/jcp/usecases/ExternalGlobalDefFileTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public void check(final PreprocessorContext context, final JcpPreprocessor.Stati
4040
assertEquals(0, stat.getCopied());
4141
assertEquals(1, stat.getPreprocessed());
4242
assertEquals(2, context.findAllInputFiles().size());
43-
assertEquals(1, context.findAllGeneratedFiles().size());
43+
assertEquals(1, context.findAllProducedFiles().size());
4444
}
4545

4646
}

jcp/src/test/java/com/igormaznitsa/jcp/usecases/GenerationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public void check(PreprocessorContext context, JcpPreprocessor.Statistics stat)
3434
assertEquals(0, stat.getCopied());
3535
assertEquals(1, stat.getPreprocessed());
3636
assertEquals(1, context.findAllInputFiles().size());
37-
assertEquals(3, context.findAllGeneratedFiles().size());
37+
assertEquals(3, context.findAllProducedFiles().size());
3838
}
3939

4040
}

jcp/src/test/java/com/igormaznitsa/jcp/usecases/IncludeAndExitTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public void check(final PreprocessorContext context, final JcpPreprocessor.Stati
3434
assertEquals(0, stat.getCopied());
3535
assertEquals(1, stat.getPreprocessed());
3636
assertEquals(3, context.findAllInputFiles().size());
37-
assertEquals(1, context.findAllGeneratedFiles().size());
37+
assertEquals(1, context.findAllProducedFiles().size());
3838
}
3939

4040
}

jcp/src/test/java/com/igormaznitsa/jcp/usecases/InsidePreprocessingTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public void check(PreprocessorContext context, JcpPreprocessor.Statistics stat)
3434
assertEquals(0, stat.getCopied());
3535
assertEquals(1, stat.getPreprocessed());
3636
assertEquals(2, context.findAllInputFiles().size());
37-
assertEquals(1, context.findAllGeneratedFiles().size());
37+
assertEquals(1, context.findAllProducedFiles().size());
3838
}
3939

4040
}

0 commit comments

Comments
 (0)