Skip to content

Commit b4c34e0

Browse files
authored
Merge pull request #288 from zeroSteiner/fix/test-runner
Update the test matrix for GitHub
2 parents 55ee59e + 721137b commit b4c34e0

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

.github/workflows/verify.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,10 @@ jobs:
3737
- '3.0'
3838
- '3.1'
3939
- '3.2'
40+
- '3.3'
41+
- '3.4'
4042
os:
41-
- ubuntu-20.04
43+
- ubuntu-22.04
4244
- ubuntu-latest
4345
exclude:
4446
- { os: ubuntu-latest, ruby: '2.7' }

spec/lib/ruby_smb/dcerpc/samr/user_properties_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
RSpec.describe RubySMB::Dcerpc::Samr::UserProperties do
22
describe '#read' do
33
context 'when reading a structure with no user properties' do
4-
let(:binary) { [ 0, 0x63, 0, 0, 0x50, 0].pack('L<L<S<S<x96<SC') }
4+
let(:binary) { [ 0, 0x63, 0, 0, 0x50, 0].pack('L<L<S<S<x96SC') }
55
let(:subject) { described_class.read(binary) }
66

77
it 'does not include the property_count' do
@@ -23,7 +23,7 @@
2323
let(:user_property1) { RubySMB::Dcerpc::Samr::UserProperty.new(property_name: 'key1', property_value: 'value1') }
2424
let(:user_property2) { RubySMB::Dcerpc::Samr::UserProperty.new(property_name: 'key2', property_value: 'value2') }
2525
let(:user_properties) { user_property1.to_binary_s + user_property2.to_binary_s }
26-
let(:binary) { [ 0, 0x63 + 2 + user_properties.length, 0, 0, 0x50, 2].pack('L<L<S<S<x96<S<S') + user_properties + "\x00".b }
26+
let(:binary) { [ 0, 0x63 + 2 + user_properties.length, 0, 0, 0x50, 2].pack('L<L<S<S<x96S<S') + user_properties + "\x00".b }
2727
let(:subject) { described_class.read(binary) }
2828

2929
it 'includes the property_count' do
@@ -73,4 +73,4 @@
7373
expect(subject.user_properties).to be_empty
7474
end
7575
end
76-
end
76+
end

0 commit comments

Comments
 (0)