Avoid extra queries for dynamic tasks for process metadata and procline

We need the dynamic task keys there and were doing a new query every
time. We only need to do a query when explicitly reloading them.

Author: rosa

lib/solid_queue/scheduler.rb

@@ -53,7 +53,7 @@ def unschedule_recurring_tasks
       end
 
       def reload_dynamic_schedule
-        recurring_schedule.reload_dynamic_tasks
+        recurring_schedule.reschedule_dynamic_tasks
         reload_metadata
       end
 

lib/solid_queue/scheduler/recurring_schedule.rb

@@ -25,6 +25,7 @@ def schedule_tasks
       wrap_in_app_executor do
         persist_static_tasks
         reload_static_tasks
+        reload_dynamic_tasks
       end
 
       configured_tasks.each do |task|
@@ -42,11 +43,12 @@ def unschedule_tasks
     end
 
     def task_keys
-      static_task_keys + dynamic_task_keys
+      configured_tasks.map(&:key)
     end
 
-    def reload_dynamic_tasks
+    def reschedule_dynamic_tasks
       wrap_in_app_executor do
+        reload_dynamic_tasks
         schedule_created_dynamic_tasks
         unschedule_deleted_dynamic_tasks
       end
@@ -60,19 +62,15 @@ def static_task_keys
       end
 
       def dynamic_tasks
-        dynamic_tasks_enabled? ? RecurringTask.dynamic : RecurringTask.none
-      end
-
-      def dynamic_task_keys
-        dynamic_tasks.pluck(:key)
+        @dynamic_tasks ||= load_dynamic_tasks
       end
 
       def dynamic_tasks_enabled?
         @dynamic_tasks_enabled
       end
 
       def schedule_created_dynamic_tasks
-        dynamic_tasks.where.not(key: scheduled_tasks.keys).each do |task|
+        RecurringTask.dynamic.where.not(key: scheduled_tasks.keys).each do |task|
           schedule_task(task)
         end
       end
@@ -93,6 +91,14 @@ def reload_static_tasks
         @static_tasks = RecurringTask.static.where(key: static_task_keys).to_a
       end
 
+      def reload_dynamic_tasks
+        @dynamic_tasks = load_dynamic_tasks
+      end
+
+      def load_dynamic_tasks
+        dynamic_tasks_enabled? ? RecurringTask.dynamic.to_a : []
+      end
+
       def schedule(task)
         scheduled_task = Concurrent::ScheduledTask.new(task.delay_from_now, args: [ self, task, task.next_time ]) do |thread_schedule, thread_task, thread_task_run_at|
           thread_schedule.schedule_task(thread_task)