Handle 401 Unauthorized properly (#32)

Author: Takashi Kusumi

quobyte/rpc_client.go

@@ -103,13 +103,13 @@ func (client QuobyteClient) sendRequest(method string, request interface{}, resp
 	if err != nil {
 		return err
 	}
-	req, err := http.NewRequest("POST", client.url.String(), bytes.NewBuffer(message))
-	if err != nil {
-		return err
-	}
-	req.Header.Set("Content-Type", "application/json")
 	// If no cookies, serialize requests such that first successful request sets the cookies
 	for {
+		req, err := http.NewRequest("POST", client.url.String(), bytes.NewBuffer(message))
+		if err != nil {
+			return err
+		}
+		req.Header.Set("Content-Type", "application/json")
 		mux.Lock()
 		hasCookies, err := client.hasCookies()
 		if err != nil {

quobyte/rpc_client_test.go

@@ -3,6 +3,8 @@ package quobyte
 import (
 	"bytes"
 	"encoding/json"
+	"net/http"
+	"net/http/httptest"
 	"reflect"
 	"testing"
 )
@@ -175,3 +177,32 @@ func TestDecodeErrorCode(t *testing.T) {
 		}
 	}
 }
+
+func TestSendRequest(t *testing.T) {
+	// alternately return 200 (OK) / 401 (Unauthorized)
+	returnOK := true
+	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
+		if returnOK {
+			returnOK = false
+			w.Header().Add("Set-Cookie", "session=value")
+			w.WriteHeader(200)
+			w.Write([]byte("{\"result\":{\"volume_uuid\":\"1234\"}}"))
+			return
+		}
+		returnOK = true
+		w.WriteHeader(401)
+		w.Write([]byte("Unauthorized"))
+	}))
+	defer srv.Close()
+
+	client := NewQuobyteClient(srv.URL, "user", "pw")
+	for i := 0; i < 2; i++ {
+		resp := &CreateVolumeResponse{}
+		if err := client.sendRequest("dummyMethod", &request{}, &resp); err != nil {
+			t.Fatalf("Unexpected error (i=%d): %+v", i, err)
+		}
+		if got, want := resp.VolumeUuid, "1234"; got != want {
+			t.Fatalf("Unexpected result (i=%d): got %s, want %s", i, got, want)
+		}
+	}
+}