Commit 9481870
Credit HIGGS for the RHT + scalar grid pattern (per Tim Dettmers feedback)
Tim Dettmers commented in llama.cpp #20969 that 'Vector quantization +
Hadamard transform is basically HIGGS' and asked the discussion not to
credit our pattern to TurboQuant. He's right.
Verified by reading HIGGS (Malinovskii, Panferov, Ilin, Guo, Richtárik,
Alistarh, Nov 2024, arXiv:2411.17525):
| Aspect | HIGGS | TurboQuant | Variant F (us) |
|---------------------|---------------|---------------|----------------|
| Application | Weights | KV cache | KV cache |
| RHT preprocessing | YES (origin) | yes | yes |
| Quantizer | Vector grids | Scalar L-M | Scalar L-M |
| Outlier handling | — | 32-channel | — (4bo: 8 ch.) |
| Residual stage | — | 1-bit QJL | — (dropped) |
The structural pattern (RHT + grid quantization) was introduced for LLM
quantization by HIGGS in November 2024, 5 months before the published
TurboQuant. TurboQuant adapted it to KV cache with QJL + outliers. Our
Variant F dropped the QJL and outlier additions, leaving a structure
closer to HIGGS than to the published TurboQuant.
Updated:
- README.md / README.ko.md References & Citations sections to credit
HIGGS prominently, with the lineage explained
- bench/results/turboquant_reproduction.md header with the attribution
update note linking to Tim Dettmers' comment
- All references explicitly state we don't claim our shipped variant
is the TurboQuant algorithm — it's our own simplification
This is exactly the kind of external feedback that should reshape
attribution. The honest credit story is more credible than the
inflated one.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent b78ae1c commit 9481870
3 files changed
Lines changed: 17 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
480 | 480 | | |
481 | 481 | | |
482 | 482 | | |
483 | | - | |
| 483 | + | |
484 | 484 | | |
485 | | - | |
486 | | - | |
487 | | - | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
488 | 489 | | |
489 | 490 | | |
490 | | - | |
| 491 | + | |
491 | 492 | | |
492 | 493 | | |
493 | 494 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
495 | 495 | | |
496 | 496 | | |
497 | 497 | | |
498 | | - | |
| 498 | + | |
499 | 499 | | |
500 | | - | |
501 | | - | |
502 | | - | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
503 | 504 | | |
504 | 505 | | |
505 | | - | |
| 506 | + | |
506 | 507 | | |
507 | 508 | | |
508 | 509 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
2 | 6 | | |
3 | 7 | | |
4 | 8 | | |
| |||
0 commit comments