Fix: suppress Foo[...] suggestion when annotation uses keyword args - Fixes #16506

Author: vpawela

mypy/fastparse.py

@@ -1957,7 +1957,7 @@ def visit_Call(self, e: Call) -> Type:
 
         if not isinstance(self.parent(), ast3.List):
             note = None
-            if constructor:
+            if constructor and not e.keywords and len(e.args) == 1:
                 note = "Suggestion: use {0}[...] instead of {0}(...)".format(constructor)
             return self.invalid_type(e, note=note)
         if not constructor:

test-data/unit/check-fastparse.test

@@ -207,6 +207,15 @@ def f(a: Foo(int)) -> int:
 main:7: error: Invalid type comment or annotation
 main:7: note: Suggestion: use Foo[...] instead of Foo(...)
 
+[case testFasterParseTypeErrorCustomNoSuggestionForKeywordArgs_no_native_parse]
+from typing import TypeVar, Generic
+T = TypeVar('T')
+class Foo(Generic[T]):
+	pass
+x: Foo(arg=1)
+[out]
+main:5: error: Invalid type comment or annotation
+
 [case testFastParseMatMul]
 
 from typing import Any