Use meson to build C extensions

Author: sdispater

build.py

@@ -1,84 +1,32 @@
-import os
-import shutil
-import sys
+import subprocess
 
-from distutils.command.build_ext import build_ext
-from distutils.core import Distribution
-from distutils.core import Extension
-from distutils.errors import CCompilerError
-from distutils.errors import DistutilsExecError
-from distutils.errors import DistutilsPlatformError
+from pathlib import Path
 
 
-# C Extensions
-with_extensions = os.getenv("PENDULUM_EXTENSIONS", None)
+def meson(*args):
+    subprocess.call(["meson"] + list(args))
 
-if with_extensions == "1" or with_extensions is None:
-    with_extensions = True
 
-if with_extensions == "0" or hasattr(sys, "pypy_version_info"):
-    with_extensions = False
+def _build():
+    build_dir = Path(__file__).parent.joinpath("build")
+    build_dir.mkdir(parents=True, exist_ok=True)
 
-extensions = []
-if with_extensions:
-    extensions = [
-        Extension("pendulum._extensions._helpers", ["pendulum/_extensions/_helpers.c"]),
-        Extension("pendulum.parsing._iso8601", ["pendulum/parsing/_iso8601.c"]),
-    ]
-
-
-class BuildFailed(Exception):
-
-    pass
-
-
-class ExtBuilder(build_ext):
-    # This class allows C extension building to fail.
-
-    built_extensions = []
-
-    def run(self):
-        try:
-            build_ext.run(self)
-        except (DistutilsPlatformError, FileNotFoundError):
-            print(
-                "  Unable to build the C extensions, "
-                "Pendulum will use the pure python code instead."
-            )
-
-    def build_extension(self, ext):
-        try:
-            build_ext.build_extension(self, ext)
-        except (CCompilerError, DistutilsExecError, DistutilsPlatformError, ValueError):
-            print(
-                f'  Unable to build the "{ext.name}" C extension, '
-                "Pendulum will use the pure python version of the extension."
-            )
+    meson("setup", build_dir.as_posix())
+    meson("compile", "-C", build_dir.as_posix())
+    meson("install", "-C", build_dir.as_posix())
 
 
 def build(setup_kwargs):
     """
     This function is mandatory in order to build the extensions.
     """
-    distribution = Distribution({"name": "pendulum", "ext_modules": extensions})
-    distribution.package_dir = "pendulum"
-
-    cmd = ExtBuilder(distribution)
-    cmd.ensure_finalized()
-    cmd.run()
-
-    # Copy built extensions back to the project
-    for output in cmd.get_outputs():
-        relative_extension = os.path.relpath(output, cmd.build_lib)
-        if not os.path.exists(output):
-            continue
-
-        shutil.copyfile(output, relative_extension)
-        mode = os.stat(relative_extension).st_mode
-        mode |= (mode & 0o444) >> 2
-        os.chmod(relative_extension, mode)
-
-    return setup_kwargs
+    try:
+        _build()
+    except Exception:
+        print(
+            "  Unable to build C extensions, "
+            "Pendulum will use the pure python version of the extensions."
+        )
 
 
 if __name__ == "__main__":

meson.build

@@ -0,0 +1,20 @@
+project('pendulum C extensions', 'c')
+
+py_mod = import('python')
+py = py_mod.find_installation()
+py_dep = py.dependency()
+
+extensions = [
+  ['_helpers', 'pendulum/_extensions/_helpers.c', meson.source_root() / 'pendulum/_extensions/'],
+  ['_iso8601', 'pendulum/parsing/_iso8601.c', meson.source_root() / 'pendulum/parsing/'],
+]
+
+foreach extension : extensions
+  py.extension_module(
+    extension[0],
+    extension[1],
+    dependencies : py_dep,
+    install : true,
+    install_dir: extension[2]
+  )
+endforeach

pendulum/parsing/_iso8601.c

@@ -522,7 +522,6 @@ Parsed* _parse_iso8601_datetime(char *str, Parsed *parsed) {
     int leap = 0;
     int separators = 0;
     int time = 0;
-    int has_hour = 0;
     int i;
     int j;
 
@@ -773,7 +772,6 @@ Parsed* _parse_iso8601_datetime(char *str, Parsed *parsed) {
                 }
 
                 parsed->hour = time;
-                has_hour = 1;
                 break;
             case 4:
                 // Hours and minutes
@@ -786,7 +784,6 @@ Parsed* _parse_iso8601_datetime(char *str, Parsed *parsed) {
 
                 parsed->hour = time / 100;
                 parsed->minute = time % 100;
-                has_hour = 1;
                 break;
             case 6:
                 // Hours, minutes and seconds
@@ -800,7 +797,6 @@ Parsed* _parse_iso8601_datetime(char *str, Parsed *parsed) {
                 parsed->hour = time / 10000;
                 parsed->minute = time / 100 % 100;
                 parsed->second = time % 100;
-                has_hour = 1;
                 break;
             default:
                 // Any other case is wrong
@@ -942,7 +938,6 @@ Parsed* _parse_iso8601_duration(char *str, Parsed *parsed) {
     int fraction = 0;
     int has_ymd = 0;
     int has_week = 0;
-    int has_year = 0;
     int has_month = 0;
     int has_day = 0;
     int has_hour = 0;
@@ -979,7 +974,6 @@ Parsed* _parse_iso8601_duration(char *str, Parsed *parsed) {
                 fraction = 0;
                 in_fraction = 0;
                 has_ymd = 1;
-                has_year = 1;
 
                 break;
             case 'M':

poetry.lock

@@ -12,9 +12,10 @@ keywords = ['datetime', 'date', 'time']
 
 packages = [
     { include = "pendulum" },
-    #{include = "tests", format = "sdist"},
+    { include = "tests", format = "sdist" },
 ]
 include = [
+    { path = "meson.build", format = "sdist" },
     { path = "pendulum/py.typed" },
     # C extensions must be included in the wheel distributions
     { path = "pendulum/_extensions/*.so", format = "wheel" },
@@ -56,6 +57,13 @@ babel = "^2.10.3"
 cleo = "^1.0.0a5"
 tox = "^3.25.1"
 
+[tool.poetry.group.build]
+optional = true
+
+[tool.poetry.group.build.dependencies]
+meson = "^0.63.2"
+ninja = "^1.10.2.3"
+
 [tool.poetry.build]
 generate-setup-file = false
 script = "build.py"
@@ -171,5 +179,5 @@ omit = [
 ]
 
 [build-system]
-requires = ["poetry-core>=1.1.0a6"]
+requires = ["poetry-core>=1.1.0a6", "meson", "ninja"]
 build-backend = "poetry.core.masonry.api"