disable verbosity by default when directly using Pyro() (#231)

zingale · web-flow · commit 0e34de967abb · 2024-09-01T18:29:44.000-04:00
Now in a notebook, we don't get the "pyro..." message or the message from the initial conditions. This can still
be overridden by passing a verbosity into Pyro() via the parameters dictionary.
diff --git a/examples/examples.ipynb b/examples/examples.ipynb
diff --git a/pyro/advection/problems/smooth.py b/pyro/advection/problems/smooth.py
@@ -10,9 +10,9 @@
 
 def init_data(my_data, rp):
     """ initialize the smooth advection problem """
-    del rp  # this problem doesn't use runtime params
 
-    msg.bold("initializing the smooth advection problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the smooth advection problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/advection/problems/tophat.py b/pyro/advection/problems/tophat.py
@@ -8,9 +8,9 @@
 
 def init_data(myd, rp):
     """ initialize the tophat advection problem """
-    del rp  # this problem doesn't use runtime params
 
-    msg.bold("initializing the tophat advection problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the tophat advection problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(myd, patch.CellCenterData2d):
diff --git a/pyro/advection_nonuniform/problems/slotted.py b/pyro/advection_nonuniform/problems/slotted.py
@@ -8,7 +8,9 @@
 
 def init_data(my_data, rp):
     """ initialize the slotted advection problem """
-    msg.bold("initializing the slotted advection problem...")
+
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the slotted advection problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/burgers/problems/converge.py b/pyro/burgers/problems/converge.py
@@ -10,9 +10,9 @@
 
 def init_data(my_data, rp):
     """ initialize the smooth burgers convergence problem """
-    del rp  # this problem doesn't use runtime params
 
-    msg.bold("initializing the smooth burgers convergence problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the smooth burgers convergence problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/burgers/problems/test.py b/pyro/burgers/problems/test.py
@@ -8,9 +8,9 @@
 
 def init_data(myd, rp):
     """ initialize the burgers test problem """
-    del rp  # this problem doesn't use runtime params
 
-    msg.bold("initializing the burgers test problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the burgers test problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(myd, patch.CellCenterData2d):
diff --git a/pyro/burgers/problems/tophat.py b/pyro/burgers/problems/tophat.py
@@ -8,9 +8,9 @@
 
 def init_data(myd, rp):
     """ initialize the tophat burgers problem """
-    del rp  # this problem doesn't use runtime params
 
-    msg.bold("initializing the tophat burgers problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the tophat burgers problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(myd, patch.CellCenterData2d):
diff --git a/pyro/compressible/problems/acoustic_pulse.py b/pyro/compressible/problems/acoustic_pulse.py
@@ -12,7 +12,8 @@ def init_data(myd, rp):
     """initialize the acoustic_pulse problem.  This comes from
     McCourquodale & Coella 2011"""
 
-    msg.bold("initializing the acoustic pulse problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the acoustic pulse problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(myd, (patch.CellCenterData2d, fv.FV2d)):
diff --git a/pyro/compressible/problems/advect.py b/pyro/compressible/problems/advect.py
@@ -11,7 +11,8 @@
 def init_data(my_data, rp):
     """ initialize a smooth advection problem for testing convergence """
 
-    msg.bold("initializing the advect problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the advect problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/compressible/problems/bubble.py b/pyro/compressible/problems/bubble.py
@@ -11,7 +11,8 @@
 def init_data(my_data, rp):
     """ initialize the bubble problem """
 
-    msg.bold("initializing the bubble problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the bubble problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/compressible/problems/gresho.py b/pyro/compressible/problems/gresho.py
@@ -11,7 +11,8 @@
 def init_data(my_data, rp):
     """ initialize the Gresho vortex problem """
 
-    msg.bold("initializing the Gresho vortex problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the Gresho vortex problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/compressible/problems/hse.py b/pyro/compressible/problems/hse.py
@@ -11,7 +11,8 @@
 def init_data(my_data, rp):
     """ initialize the HSE problem """
 
-    msg.bold("initializing the HSE problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the HSE problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/compressible/problems/kh.py b/pyro/compressible/problems/kh.py
@@ -9,7 +9,8 @@
 def init_data(my_data, rp):
     """ initialize the Kelvin-Helmholtz problem """
 
-    msg.bold("initializing the Kelvin-Helmholtz problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the Kelvin-Helmholtz problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/compressible/problems/logo.py b/pyro/compressible/problems/logo.py
@@ -12,7 +12,8 @@
 def init_data(my_data, rp):
     """ initialize the logo problem """
 
-    msg.bold("initializing the logo problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the logo problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/compressible/problems/quad.py b/pyro/compressible/problems/quad.py
@@ -11,7 +11,8 @@
 def init_data(my_data, rp):
     """ initialize the quadrant problem """
 
-    msg.bold("initializing the quadrant problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the quadrant problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/compressible/problems/ramp.py b/pyro/compressible/problems/ramp.py
@@ -12,7 +12,8 @@
 def init_data(my_data, rp):
     """ initialize the double Mach reflection problem """
 
-    msg.bold("initializing the double Mach reflection problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the double Mach reflection problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/compressible/problems/rt.py b/pyro/compressible/problems/rt.py
@@ -11,7 +11,8 @@
 def init_data(my_data, rp):
     """ initialize the rt problem """
 
-    msg.bold("initializing the rt problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the rt problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/compressible/problems/rt2.py b/pyro/compressible/problems/rt2.py
@@ -15,10 +15,10 @@
 
 
 def init_data(my_data, rp):
-
     """ initialize the rt problem """
 
-    msg.bold("initializing the rt problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the rt problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/compressible/problems/sedov.py b/pyro/compressible/problems/sedov.py
@@ -12,7 +12,8 @@
 def init_data(my_data, rp):
     """ initialize the sedov problem """
 
-    msg.bold("initializing the sedov problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the sedov problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/compressible/problems/sod.py b/pyro/compressible/problems/sod.py
@@ -9,7 +9,8 @@
 def init_data(my_data, rp):
     """ initialize the sod problem """
 
-    msg.bold("initializing the sod problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the sod problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/diffusion/problems/gaussian.py b/pyro/diffusion/problems/gaussian.py
@@ -18,7 +18,8 @@ def phi_analytic(dist, t, t_0, k, phi_1, phi_2):
 def init_data(my_data, rp):
     """ initialize the Gaussian diffusion problem """
 
-    msg.bold("initializing the Gaussian diffusion problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the Gaussian diffusion problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/incompressible/problems/converge.py b/pyro/incompressible/problems/converge.py
@@ -36,9 +36,9 @@
 
 def init_data(my_data, rp):
     """ initialize the incompressible converge problem """
-    del rp  # this problem doesn't use runtime params
 
-    msg.bold("initializing the incompressible converge problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the incompressible converge problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/incompressible/problems/shear.py b/pyro/incompressible/problems/shear.py
@@ -27,7 +27,8 @@
 def init_data(my_data, rp):
     """ initialize the incompressible shear problem """
 
-    msg.bold("initializing the incompressible shear problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the incompressible shear problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/incompressible_viscous/problems/cavity.py b/pyro/incompressible_viscous/problems/cavity.py
@@ -18,9 +18,9 @@
 
 def init_data(my_data, rp):
     """ initialize the lid-driven cavity """
-    del rp  # this problem doesn't use runtime params
 
-    msg.bold("initializing the lid-driven cavity problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the lid-driven cavity problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/incompressible_viscous/problems/converge.py b/pyro/incompressible_viscous/problems/converge.py
@@ -35,9 +35,9 @@
 
 def init_data(my_data, rp):
     """ initialize the incompressible viscous converge problem """
-    del rp  # this problem doesn't use runtime params
 
-    msg.bold("initializing the incompressible viscous converge problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the incompressible viscous converge problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/incompressible_viscous/problems/shear.py b/pyro/incompressible_viscous/problems/shear.py
@@ -27,7 +27,8 @@
 def init_data(my_data, rp):
     """ initialize the incompressible shear problem """
 
-    msg.bold("initializing the incompressible shear problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the incompressible shear problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/lm_atm/problems/bubble.py b/pyro/lm_atm/problems/bubble.py
@@ -11,7 +11,8 @@
 def init_data(my_data, base, rp):
     """ initialize the bubble problem """
 
-    msg.bold("initializing the bubble problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the bubble problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/lm_atm/problems/gresho.py b/pyro/lm_atm/problems/gresho.py
@@ -11,7 +11,8 @@
 def init_data(my_data, base, rp):
     """ initialize the Gresho vortex problem """
 
-    msg.bold("initializing the Gresho vortex problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the Gresho vortex problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/pyro_sim.py b/pyro/pyro_sim.py
@@ -49,7 +49,8 @@ def __init__(self, solver_name, from_commandline=False):
             runtime vis by default.
         """
 
-        msg.bold('pyro ...')
+        if from_commandline:
+            msg.bold('pyro ...')
 
         if solver_name not in valid_solvers:
             msg.fail(f"ERROR: {solver_name} is not a valid solver")
@@ -118,12 +119,11 @@ def initialize_problem(self, problem_name, inputs_file=None, inputs_dict=None,
 
             self.rp.load_params(inputs_file, no_new=1)
 
-        # manually override the dovis default
+        # manually override the dovis and verbose defaults
         # for Jupyter, we want runtime vis disabled by default
-        if self.from_commandline:
-            self.rp.set_param("vis.dovis", 1)
-        else:
+        if not self.from_commandline:
             self.rp.set_param("vis.dovis", 0)
+            self.rp.set_param("driver.verbose", 0)
 
         if inputs_dict is not None:
             for k, v in inputs_dict.items():
diff --git a/pyro/swe/problems/acoustic_pulse.py b/pyro/swe/problems/acoustic_pulse.py
@@ -12,7 +12,8 @@ def init_data(myd, rp):
     """initialize the acoustic_pulse problem.  This comes from
     McCourquodale & Coella 2011"""
 
-    msg.bold("initializing the acoustic pulse problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the acoustic pulse problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(myd, patch.CellCenterData2d):
diff --git a/pyro/swe/problems/advect.py b/pyro/swe/problems/advect.py
@@ -11,7 +11,8 @@
 def init_data(my_data, rp):
     """ initialize a smooth advection problem for testing convergence """
 
-    msg.bold("initializing the advect problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the advect problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/swe/problems/dam.py b/pyro/swe/problems/dam.py
@@ -9,7 +9,8 @@
 def init_data(my_data, rp):
     """ initialize the dam problem """
 
-    msg.bold("initializing the dam problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the dam problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/swe/problems/kh.py b/pyro/swe/problems/kh.py
@@ -9,7 +9,8 @@
 def init_data(my_data, rp):
     """ initialize the Kelvin-Helmholtz problem """
 
-    msg.bold("initializing the Kelvin-Helmholtz problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the Kelvin-Helmholtz problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/swe/problems/logo.py b/pyro/swe/problems/logo.py
@@ -11,9 +11,9 @@
 
 def init_data(my_data, rp):
     """ initialize the sedov problem """
-    del rp  # this problem doesn't use runtime params
 
-    msg.bold("initializing the logo problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the logo problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
diff --git a/pyro/swe/problems/quad.py b/pyro/swe/problems/quad.py
@@ -11,7 +11,8 @@
 def init_data(my_data, rp):
     """ initialize the quadrant problem """
 
-    msg.bold("initializing the quadrant problem...")
+    if rp.get_param("driver.verbose"):
+        msg.bold("initializing the quadrant problem...")
 
     # make sure that we are passed a valid patch object
     if not isinstance(my_data, patch.CellCenterData2d):
