Skip to content

Commit 4e9e033

Browse files
authored
tests: add asserts for expected results (#197)
1 parent 35a0064 commit 4e9e033

1 file changed

Lines changed: 21 additions & 29 deletions

File tree

tests/test_general.py

Lines changed: 21 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -168,17 +168,12 @@ def dummy_func(arg_1, arg_2):
168168
"""Some function."""
169169
return arg_1 + arg_2
170170

171-
result = dummy_func.precache_value(2, 2, value_to_cache=5)
172-
assert result == 5
173-
result = dummy_func(2, 2)
174-
assert result == 5
171+
assert dummy_func.precache_value(2, 2, value_to_cache=5) == 5
172+
assert dummy_func(2, 2) == 5
175173
dummy_func.clear_cache()
176-
result = dummy_func(2, 2)
177-
assert result == 4
178-
result = dummy_func.precache_value(2, arg_2=2, value_to_cache=5)
179-
assert result == 5
180-
result = dummy_func(2, arg_2=2)
181-
assert result == 5
174+
assert dummy_func(2, 2) == 4
175+
assert dummy_func.precache_value(2, arg_2=2, value_to_cache=5) == 5
176+
assert dummy_func(2, arg_2=2) == 5
182177

183178

184179
@pytest.mark.parametrize(
@@ -201,12 +196,10 @@ def takes_2_seconds(self, arg_1, arg_2):
201196
test_object_2 = DummyClass()
202197
test_object_1.takes_2_seconds.clear_cache()
203198
test_object_2.takes_2_seconds.clear_cache()
204-
result_1 = test_object_1.takes_2_seconds(1, 2)
205-
assert result_1 == 3
199+
assert test_object_1.takes_2_seconds(1, 2) == 3
206200
start = time()
207-
result_2 = test_object_2.takes_2_seconds(1, 2)
201+
assert test_object_2.takes_2_seconds(1, 2) == 3
208202
end = time()
209-
assert result_2 == 3
210203
assert end - start < 1
211204

212205

@@ -292,10 +285,10 @@ def dummy_func(a: int, b: int = 2, c: int = 3):
292285

293286
dummy_func.clear_cache()
294287
assert count == 0
295-
dummy_func(1, 2, 3)
296-
dummy_func(1, 2, c=3)
297-
dummy_func(1, b=2, c=3)
298-
dummy_func(a=1, b=2, c=3)
288+
assert dummy_func(1, 2, 3) == 6
289+
assert dummy_func(1, 2, c=3) == 6
290+
assert dummy_func(1, b=2, c=3) == 6
291+
assert dummy_func(a=1, b=2, c=3) == 6
299292
assert count == 1
300293

301294

@@ -310,10 +303,10 @@ def dummy_func(a: list, b: list = [2]):
310303

311304
dummy_func.clear_cache()
312305
assert count == 0
313-
dummy_func([1])
314-
dummy_func([1], [2])
315-
dummy_func([1], b=[2])
316-
dummy_func(a=[1], b=[2])
306+
assert dummy_func([1]) == [1, 2]
307+
assert dummy_func([1], [2]) == [1, 2]
308+
assert dummy_func([1], b=[2]) == [1, 2]
309+
assert dummy_func(a=[1], b=[2]) == [1, 2]
317310
assert count == 1
318311

319312

@@ -328,10 +321,9 @@ def dummy_func(a, b):
328321

329322
dummy_func.clear_cache()
330323
assert count == 0
331-
dummy_func(a=1, b=2)
332-
dummy_func(a=1, b=2)
333-
assert count == 1
334-
dummy_func(b=2, a=1)
324+
assert dummy_func(a=1, b=2) == 3
325+
assert dummy_func(a=1, b=2) == 3
326+
assert dummy_func(b=2, a=1) == 3
335327
assert count == 1
336328

337329

@@ -346,9 +338,9 @@ def dummy_func(a, b=2):
346338

347339
dummy_func.clear_cache()
348340
assert count == 0
349-
dummy_func(1)
350-
dummy_func(a=1)
351-
dummy_func(a=1, b=2)
341+
assert dummy_func(1) == 3
342+
assert dummy_func(a=1) == 3
343+
assert dummy_func(a=1, b=2) == 3
352344
assert count == 1
353345

354346

0 commit comments

Comments
 (0)