Skip to content

Commit 6dd98e6

Browse files
committed
Remove fuzzy flag mutation from add_conflict
The add_conflict method was mutating the message's fuzzy flag as a side effect, which is unexpected. The caller (ConcatenateCatalog.run) now explicitly sets the fuzzy flag when adding a conflicting message.
1 parent f1618e5 commit 6dd98e6

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

babel/messages/catalog.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -790,7 +790,7 @@ def __setitem__(self, id: _MessageID, message: Message) -> None:
790790
)
791791
self._messages[key] = message
792792

793-
def add_conflict(self, message: Message, filename: str, project: str, version: str, fuzzy: bool = True):
793+
def add_conflict(self, message: Message, filename: str, project: str, version: str):
794794
key = message.id
795795
self._conflicts[key].append({
796796
'message': message,
@@ -799,9 +799,6 @@ def add_conflict(self, message: Message, filename: str, project: str, version: s
799799
'version': version,
800800
})
801801

802-
if fuzzy:
803-
message.flags |= {'fuzzy'}
804-
805802
def get_conflicts(self, id: _MessageID) -> list[ConflictInfo]:
806803
return self._conflicts.get(id, [])
807804

babel/messages/frontend.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -995,6 +995,7 @@ def run(self):
995995
if count > 1 and not self.use_first and diff_string_count > 1:
996996
filename = os.path.basename(path)
997997
catalog.add_conflict(message, filename, template.project, template.version)
998+
message.flags |= {'fuzzy'}
998999

9991000
catalog[message.id] = message
10001001

0 commit comments

Comments
 (0)