Nuke the somewhat broken class check for Config.clone(into=)

Author: Jeff Forcier

invoke/config.py

@@ -1014,16 +1014,8 @@ def clone(self, into: Optional[Type["Config"]] = None) -> "Config":
         :returns:
             A `.Config`, or an instance of the class given to ``into``.
 
-        :raises:
-            ``TypeError``, if ``into`` is given a value and that value is not a
-            `.Config` subclass.
-
         .. versionadded:: 1.0
         """
-        # Sanity check for 'into'
-        if into is not None and not issubclass(into, self.__class__):
-            err = "'into' must be a subclass of {}!"
-            raise TypeError(err.format(self.__class__.__name__))
         # Construct new object
         klass = self.__class__ if into is None else into
         # Also allow arbitrary constructor kwargs, for subclasses where passing

sites/www/changelog.rst

@@ -2,6 +2,11 @@
 Changelog
 =========
 
+- :feature:`-` Remove the somewhat inaccurate subclass requirement around
+  `~invoke.config.Config`'s ``.clone(into=...)`` constructor call. It was
+  broken for certain use cases (such as trying to clone one subclass into a
+  sibling subclass, which would yield a ``TypeError``) and is irrelevant if one
+  is using the new type annotations.
 - :release:`2.1.3 <2023-06-14>`
 - :bug:`944` After the release of 2.1, package-style task modules started
   looking in the wrong place for project-level config files (inside one's eg

tests/config.py

@@ -1039,24 +1039,6 @@ def is_not_required(self):
                 c2 = c.clone()
                 assert c2.meh == "okay"
 
-            def raises_TypeError_if_value_is_not_Config_subclass(self):
-                try:
-                    Config().clone(into=17)
-                except TypeError:
-                    pass
-                else:
-                    assert False, "Non-class obj did not raise TypeError!"
-
-                class Foo:
-                    pass
-
-                try:
-                    Config().clone(into=Foo)
-                except TypeError:
-                    pass
-                else:
-                    assert False, "Non-subclass did not raise TypeError!"
-
             def resulting_clones_are_typed_as_new_class(self):
                 class MyConfig(Config):
                     pass