Preserve link annotations during FPDF.multi_cell(..., dry_run=True) (#1808)

* add tests for dry run link annotations bug

* Fix dry run link annotations bug

* note fix in change log

* fix position of text on pdf page

Author: CoLa5

CHANGELOG.md

@@ -24,6 +24,7 @@ This can also be enabled programmatically with `warnings.simplefilter('default',
 * preserve boundary-neutral formatting during bidirectional text preprocessing - _cf._ [issue #1779](https://github.com/py-pdf/fpdf2/issues/1779)
 * transform application on user space gradients - _cf._ [issue #1784](https://github.com/py-pdf/fpdf2/issues/1784)
 * dependency extras for camelot-py and endesive on pyproject.toml - _cf._ [issue #1792](https://github.com/py-pdf/fpdf2/issues/1792)
+* preserve link annotations during dry-run of pdf.multi_cell - _cf._ [issue #1807](https://github.com/py-pdf/fpdf2/issues/1807)
 ### Changed
 * skip byte-for-byte compressed data comparison when zlib-ng is detected, regardless of OS
 

fpdf/fpdf.py

@@ -4686,7 +4686,7 @@ def _disable_writing(self) -> Iterator[None]:
             self.x,
             self.y,
         )
-        annots = self.pages[self.page].annots or PDFArray()
+        annots = PDFArray(self.pages[self.page].annots or [])
         self._push_local_stack()
         try:
             yield

test/text/multi_cell_markdown_link_dry_run.pdf

@@ -147,3 +147,50 @@ def test_multi_cell_markdown_link(tmp_path):
         markdown=True,
     )
     assert_pdf_equal(pdf, HERE / "multi_cell_markdown_link.pdf", tmp_path)
+
+
+def test_multi_cell_markdown_link_dry_run(tmp_path):
+    pdf = fpdf.FPDF()
+    pdf.set_font("Helvetica")
+    pdf.add_page()
+    assert len(pdf.pages[1].annots) == 0
+
+    pdf.multi_cell(
+        pdf.epw,
+        text="**Start** [One Page Dungeon Context](https://www.dungeoncontest.com/) __End__",
+        dry_run=True,
+        markdown=True,
+        new_x="left",
+        new_y="next",
+    )
+    assert len(pdf.pages[1].annots) == 0
+
+    pdf.multi_cell(
+        pdf.epw,
+        text="**Start** [One Page Dungeon Context](https://www.dungeoncontest.com/) __End__",
+        markdown=True,
+        new_x="left",
+        new_y="next",
+    )
+    assert len(pdf.pages[1].annots) == 1
+
+    pdf.multi_cell(
+        pdf.epw,
+        text="**Start** [One Page Dungeon Context](https://www.dungeoncontest.com/) __End__",
+        dry_run=True,
+        markdown=True,
+        new_x="left",
+        new_y="next",
+    )
+    assert len(pdf.pages[1].annots) == 1
+
+    pdf.multi_cell(
+        pdf.epw,
+        text="**Start** [One Page Dungeon Context](https://www.dungeoncontest.com/) __End__",
+        markdown=True,
+        new_x="left",
+        new_y="next",
+    )
+    assert len(pdf.pages[1].annots) == 2
+
+    assert_pdf_equal(pdf, HERE / "multi_cell_markdown_link_dry_run.pdf", tmp_path)