Skip to content

Commit ff3bd2d

Browse files
authored
fix: use maven release type for release-please (#1967)
## Summary - Revert the v1.6.0 release commit (manifest + CHANGELOG) since the deploy failed — pom.xml files still had `-SNAPSHOT` versions - Change `release-type` from `java` to `maven` in the release-please config so it auto-discovers and updates all `pom.xml` versions in the release commit - Remove `prometheus-metrics-parent/pom.xml` from `extra-files` since the maven strategy handles it automatically The `java` release type only updates CHANGELOG and the manifest. The `maven` type does XML-aware pom.xml version updates, which is what we need. The v1.6.0 tag and GitHub release have already been deleted. ## Test plan - [ ] CI passes - [ ] After merge, release-please creates a new release PR that includes pom.xml version updates - [ ] Deploy to Maven Central succeeds --------- Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
1 parent 9862869 commit ff3bd2d

46 files changed

Lines changed: 46 additions & 78 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
".": "1.6.0"
2+
".": "1.5.0"
33
}

.github/config/release-please-config.json

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,8 @@
44
"pull-request-footer": "> [!IMPORTANT]\n> Close and reopen this PR to trigger CI checks.",
55
"packages": {
66
".": {
7-
"release-type": "java",
8-
"extra-files": [
9-
"prometheus-metrics-parent/pom.xml",
10-
"integration-tests/it-spring-boot-smoke-test/pom.xml"
11-
]
7+
"release-type": "maven",
8+
"extra-files": ["integration-tests/it-spring-boot-smoke-test/pom.xml"]
129
}
1310
}
1411
}

CHANGELOG.md

Lines changed: 0 additions & 29 deletions
This file was deleted.

benchmarks/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<parent>
99
<groupId>io.prometheus</groupId>
1010
<artifactId>client_java</artifactId>
11-
<version>1.6.0-SNAPSHOT</version>
11+
<version>1.5.0-SNAPSHOT</version>
1212
</parent>
1313

1414
<artifactId>benchmarks</artifactId>

examples/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<groupId>io.prometheus</groupId>
88
<artifactId>client_java</artifactId>
9-
<version>1.6.0-SNAPSHOT</version>
9+
<version>1.5.0-SNAPSHOT</version>
1010
</parent>
1111

1212
<artifactId>examples</artifactId>

integration-tests/it-common/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<groupId>io.prometheus</groupId>
88
<artifactId>integration-tests</artifactId>
9-
<version>1.6.0-SNAPSHOT</version>
9+
<version>1.5.0-SNAPSHOT</version>
1010
</parent>
1111

1212
<artifactId>it-common</artifactId>

integration-tests/it-exporter/it-exporter-duplicate-metrics-sample/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<groupId>io.prometheus</groupId>
88
<artifactId>it-exporter</artifactId>
9-
<version>1.6.0-SNAPSHOT</version>
9+
<version>1.5.0-SNAPSHOT</version>
1010
</parent>
1111

1212
<artifactId>it-exporter-duplicate-metrics-sample</artifactId>

integration-tests/it-exporter/it-exporter-httpserver-sample/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<groupId>io.prometheus</groupId>
88
<artifactId>it-exporter</artifactId>
9-
<version>1.6.0-SNAPSHOT</version>
9+
<version>1.5.0-SNAPSHOT</version>
1010
</parent>
1111

1212
<artifactId>it-exporter-httpserver-sample</artifactId>

integration-tests/it-exporter/it-exporter-no-protobuf/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<groupId>io.prometheus</groupId>
88
<artifactId>it-exporter</artifactId>
9-
<version>1.6.0-SNAPSHOT</version>
9+
<version>1.5.0-SNAPSHOT</version>
1010
</parent>
1111

1212
<artifactId>it-exporter-no-protobuf</artifactId>

integration-tests/it-exporter/it-exporter-servlet-jetty-sample/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<groupId>io.prometheus</groupId>
88
<artifactId>it-exporter</artifactId>
9-
<version>1.6.0-SNAPSHOT</version>
9+
<version>1.5.0-SNAPSHOT</version>
1010
</parent>
1111

1212
<artifactId>it-exporter-servlet-jetty-sample</artifactId>

0 commit comments

Comments
 (0)