Phase 2 - more name fixes, added openssl to seed rng where available, fallback to os.time() if unavailable.

Author: SpinnySpiwal

src/prometheus/compiler/compile_core.lua

@@ -9,7 +9,6 @@ local statementHandlers = require("prometheus.compiler.statements");
 local expressionHandlers = require("prometheus.compiler.expressions");
 local Ast = require("prometheus.ast");
 local logger = require("logger");
-local AstKind = Ast.AstKind;
 
 return function(Compiler)
     compileTop(Compiler);

src/prometheus/namegenerators/Il.lua

@@ -15,27 +15,27 @@ local offset = 0;
 local VarDigits = chararray("Il1");
 local VarStartDigits = chararray("Il");
 
-local function generateName(id, scope)
+local function generateName(id, _)
 	local name = ''
 	id = id + offset;
 	local d = id % #VarStartDigits
 	id = (id - d) / #VarStartDigits
 	name = name..VarStartDigits[d+1]
 	while id > 0 do
-		local d = id % #VarDigits
-		id = (id - d) / #VarDigits
-		name = name..VarDigits[d+1]
+		local e = id % #VarDigits
+		id = (id - e) / #VarDigits
+		name = name..VarDigits[e+1]
 	end
 	return name
 end
 
-local function prepare(ast)
+local function prepare(_)
 	util.shuffle(VarDigits);
 	util.shuffle(VarStartDigits);
 	offset = math.random(3 ^ MIN_CHARACTERS, 3 ^ MAX_INITIAL_CHARACTERS);
 end
 
 return {
-	generateName = generateName, 
+	generateName = generateName,
 	prepare = prepare
 };

src/prometheus/namegenerators/confuse.lua

@@ -5,7 +5,6 @@
 -- This Script provides a function for generation of confusing variable names
 
 local util = require("prometheus.util");
-local chararray = util.chararray;
 
 local varNames = {
     "index",
@@ -146,24 +145,24 @@ local varNames = {
     "a", "b", "c", "i", "j", "m",
 }
 
-local function generateName(id, scope)
+local function generateName(id, _)
     local name = {};
     local d = id % #varNames
 	id = (id - d) / #varNames
 	table.insert(name, varNames[d + 1]);
 	while id > 0 do
-		local d = id % #varNames
-		id = (id - d) / #varNames
-		table.insert(name, varNames[d + 1]);
+		local e = id % #varNames
+		id = (id - e) / #varNames
+		table.insert(name, varNames[e + 1]);
 	end
 	return table.concat(name, "_");
 end
 
-local function prepare(ast)
+local function prepare(_)
     util.shuffle(varNames);
 end
 
 return {
-	generateName = generateName, 
+	generateName = generateName,
 	prepare = prepare
 };

src/prometheus/namegenerators/mangled.lua

@@ -8,19 +8,18 @@
 local util = require("prometheus.util");
 local chararray = util.chararray;
 
-local idGen = 0
 local VarDigits = chararray("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_");
 local VarStartDigits = chararray("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ");
 
-return function(id, scope)
+return function(id, _)
 	local name = ''
 	local d = id % #VarStartDigits
 	id = (id - d) / #VarStartDigits
 	name = name..VarStartDigits[d+1]
 	while id > 0 do
-		local d = id % #VarDigits
-		id = (id - d) / #VarDigits
-		name = name..VarDigits[d+1]
+		local e = id % #VarDigits
+		id = (id - e) / #VarDigits
+		name = name..VarDigits[e+1]
 	end
 	return name
 end

src/prometheus/namegenerators/mangled_shuffled.lua

@@ -11,25 +11,25 @@ local chararray = util.chararray;
 local VarDigits = chararray("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_");
 local VarStartDigits = chararray("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ");
 
-local function generateName(id, scope)
+local function generateName(id, _)
 	local name = ''
 	local d = id % #VarStartDigits
 	id = (id - d) / #VarStartDigits
 	name = name..VarStartDigits[d+1]
 	while id > 0 do
-		local d = id % #VarDigits
-		id = (id - d) / #VarDigits
-		name = name..VarDigits[d+1]
+		local e = id % #VarDigits
+		id = (id - e) / #VarDigits
+		name = name..VarDigits[e+1]
 	end
 	return name
 end
 
-local function prepare(ast)
+local function prepare(_)
 	util.shuffle(VarDigits);
 	util.shuffle(VarStartDigits);
 end
 
 return {
-	generateName = generateName, 
+	generateName = generateName,
 	prepare = prepare
 };

src/prometheus/namegenerators/number.lua

@@ -6,6 +6,6 @@
 
 local PREFIX = "_";
 
-return function(id, scope)
+return function(id, _)
 	return PREFIX .. tostring(id);
 end

src/prometheus/pipeline.lua

@@ -105,15 +105,15 @@ function Pipeline:addStep(step)
 	table.insert(self.steps, step);
 end
 
-function Pipeline:resetSteps(step)
+function Pipeline:resetSteps(_)
 	self.steps = {};
 end
 
 function Pipeline:getSteps()
 	return self.steps;
 end
 
-function Pipeline:setOption(name, value)
+function Pipeline:setOption(name, _)
 	assert(false, "TODO");
 	if(Pipeline.DefaultSettings[name] ~= nil) then
 
@@ -159,11 +159,21 @@ function Pipeline:apply(code, filename)
 	local startTime = gettime();
 	filename = filename or "Anonymous Script";
 	logger:info(string.format("Applying Obfuscation Pipeline to %s ...", filename));
+
 	-- Seed the Random Generator
 	if(self.Seed > 0) then
 		math.randomseed(self.Seed);
 	else
-		math.randomseed(os.time())
+		-- try to use secure random number generator
+		local success, seed = pcall(function()
+			return tonumber(io.popen("openssl rand -hex 8"):read("*a"):gsub("\n", ""), 16)
+		end)
+		if success then
+			math.randomseed(seed)
+		else
+			logger:warn("OpenSSL is unavailable. Falling back to unix time.");
+			math.randomseed(os.time())
+		end
 	end
 
 	logger:info("Parsing ...");