Fix race on sending stdin close event

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

Author: tonistiigi

integration-cli/docker_cli_run_test.go

@@ -4666,95 +4666,3 @@ func (s *delayedReader) Read([]byte) (int, error) {
 	time.Sleep(500 * time.Millisecond)
 	return 0, io.EOF
 }
-
-// #28823 (originally #28639)
-func (s *DockerSuite) TestRunMountReadOnlyDevShm(c *check.C) {
-	testRequires(c, SameHostDaemon, DaemonIsLinux)
-	emptyDir, err := ioutil.TempDir("", "test-read-only-dev-shm")
-	c.Assert(err, check.IsNil)
-	defer os.RemoveAll(emptyDir)
-	out, _, err := dockerCmdWithError("run", "--rm", "--read-only",
-		"-v", fmt.Sprintf("%s:/dev/shm:ro", emptyDir),
-		"busybox", "touch", "/dev/shm/foo")
-	c.Assert(err, checker.NotNil, check.Commentf(out))
-	c.Assert(out, checker.Contains, "Read-only file system")
-}
-
-// Test case for 29129
-func (s *DockerSuite) TestRunHostnameInHostMode(c *check.C) {
-	testRequires(c, DaemonIsLinux)
-
-	expectedOutput := "foobar\nfoobar"
-	out, _ := dockerCmd(c, "run", "--net=host", "--hostname=foobar", "busybox", "sh", "-c", `echo $HOSTNAME && hostname`)
-	c.Assert(strings.TrimSpace(out), checker.Equals, expectedOutput)
-}
-
-func (s *DockerRegistrySuite) TestRunWithAdditionalRegistry(c *check.C) {
-	if err := s.d.StartWithBusybox("--add-registry=" + s.reg.url); err != nil {
-		c.Fatalf("we should have been able to start the daemon with passing add-registry=%s: %v", s.reg.url, err)
-	}
-
-	bbImg := s.d.getAndTestImageEntry(c, 1, "busybox", "")
-
-	// push busybox to additional registry as "library/hello-world" and remove all local images
-	if out, err := s.d.Cmd("tag", "busybox", s.reg.url+"/busybox"); err != nil {
-		c.Fatalf("failed to tag image busybox: error %v, output %q", err, out)
-	}
-	if out, err := s.d.Cmd("rmi", "busybox"); err != nil {
-		c.Fatalf("failed to remove image busybox: %v, output: %s", err, out)
-	}
-	s.d.getAndTestImageEntry(c, 1, s.reg.url+"/busybox", bbImg.id)
-
-	// try to run fully qualified image
-	if out, err := s.d.Cmd("run", "-t", s.reg.url+"/busybox", "sh", "-c", "echo foo"); err != nil {
-		c.Fatalf("failed to run %s/busybox image: %v, output: %s", s.reg.url, err, out)
-	} else if strings.TrimSpace(out) != "foo" {
-		c.Fatalf("got unexpected output: %q", out)
-	}
-
-	// try to run unqualified
-	if out, err := s.d.Cmd("run", "-t", "busybox", "sh", "-c", "echo foo"); err != nil {
-		c.Fatalf("failed to run busybox image: %v, output: %s", err, out)
-	} else if out != "foo\r\n" {
-		c.Fatalf("got unexpected output: %q", out)
-	}
-
-	// try to run hello world from additional registry
-	if out, err := s.d.Cmd("run", "-t", s.reg.url+"/library/hello-world", "sh", "-c", "echo foo"); err == nil {
-		c.Fatalf("running container from image %s/library/hello-world should have failed; output: %s", s.reg.url, out)
-	}
-
-	// try to run hello-world from official registry
-	if out, err := s.d.Cmd("run", "-t", "library/hello-world"); err != nil {
-		c.Fatalf("failed to run library/hello-world image: %v, output: %s", err, out)
-	} else if strings.HasSuffix(strings.TrimSpace(out), "foo") {
-		c.Fatalf("got unexpected output")
-	}
-	s.d.getAndTestImageEntry(c, 2, "docker.io/hello-world", "")
-
-	// push busybox to additional registry as "library/hello-world" and remove all local images
-	if out, err := s.d.Cmd("tag", s.reg.url+"/busybox", s.reg.url+"/library/hello-world"); err != nil {
-		c.Fatalf("failed to tag image %s: error %v, output %q", s.reg.url+"/busybox", err, out)
-	}
-	if out, err := s.d.Cmd("push", s.reg.url+"/library/hello-world"); err != nil {
-		c.Fatalf("failed to push image %s: error %v, output %q", s.reg.url+"/library/hello-world", err, out)
-	}
-	args := []string{"rmi", "-f", "hello-world", "library/hello-world", "busybox"}
-	if out, err := s.d.Cmd(args...); err != nil {
-		c.Fatalf("failed to remove images %v: %v, output: %s", args[1:], err, out)
-	}
-	s.d.getAndTestImageEntry(c, 0, "", "")
-
-	// now try to run unqualified hello-world again - this time we should pull from additional registry
-	if out, err := s.d.Cmd("run", "-t", "library/hello-world", "sh", "-c", "echo foo"); err != nil {
-		c.Fatalf("failed to run library/hello-world image: %v, output: %s", err, out)
-	} else if !strings.HasSuffix(strings.TrimSpace(out), "\nfoo") {
-		c.Fatalf("got unexpected output: %q", out)
-	}
-	// image id now differs from busybox because ids are generated again upon full pull
-	hwImg := s.d.getAndTestImageEntry(c, 1, s.reg.url+"/library/hello-world", "")
-	// therefore we need to compare size
-	if bbImg.size != hwImg.size {
-		c.Fatalf("expected %s:%s and %s:%s to have equal size (%s != %s)", hwImg.name, hwImg.tag, bbImg.name, bbImg.tag, hwImg.size, bbImg.size)
-	}
-}