Skip to content

Commit ca8c3a2

Browse files
committed
simplifying config for listening
Signed-off-by: Jesse Jaggars <jjaggars@redhat.com>
1 parent 10bbce4 commit ca8c3a2

3 files changed

Lines changed: 10 additions & 30 deletions

File tree

receptor/config.py

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -110,18 +110,10 @@ def __init__(self, args=None):
110110
self.add_config_option(
111111
section='node',
112112
key='listen',
113-
default_value='receptor://0.0.0.0:8888',
114-
value_type='str',
113+
default_value=['receptor://0.0.0.0:8888'],
114+
value_type='list',
115115
hint='Set/override IP address and port to listen on. If not set here or in a config file, the default is receptor://0.0.0.0:8888.',
116116
)
117-
self.add_config_option(
118-
section='node',
119-
key='websocket_listen',
120-
default_value='',
121-
value_type='str',
122-
hint='Set IP address and port to listen on for websocket clients in the form ws[s]://addr:port. '
123-
'If not set here or in a config file then it is disabled',
124-
)
125117
self.add_config_option(
126118
section='node',
127119
key='peers',
@@ -182,17 +174,9 @@ def __init__(self, args=None):
182174
self.add_config_option(
183175
section='controller',
184176
key='listen',
185-
default_value='receptor://0.0.0.0:8888',
186-
value_type='str',
187-
hint='Set IP address and port to listen on. If not set here or in a config file, the default is receptor://0.0.0.0/0:8888.',
188-
)
189-
self.add_config_option(
190-
section='controller',
191-
key='websocket_listen',
192-
default_value='',
193-
value_type='str',
194-
hint='Set IP address and port to listen on for websocket clients in the form ws://addr:port. '
195-
'If not set here or in a config file then it is disabled',
177+
default_value=['receptor://0.0.0.0:8888'],
178+
value_type='list',
179+
hint='Set IP address and port to listen on. If not set here or in a config file, the default is receptor://0.0.0.0/0:8888. This option can be passed multiple times.',
196180
)
197181
self.add_config_option(
198182
section='controller',

receptor/controller.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,11 @@ def __init__(self, config, loop=asyncio.get_event_loop(), queue=None):
2626
self.queue = asyncio.Queue(loop=loop)
2727
self.receptor.response_queue = self.queue
2828

29-
def enable_server(self, listen_url):
30-
listener = self.connection_manager.get_listener(listen_url)
31-
logger.info("Serving on %s", listen_url)
32-
self.loop.create_task(listener)
33-
34-
def enable_websocket_server(self, listen_url):
35-
self.enable_server(listen_url)
29+
def enable_server(self, listen_urls):
30+
for url in listen_urls:
31+
listener = self.connection_manager.get_listener(url)
32+
logger.info("Serving on %s", url)
33+
self.loop.create_task(listener)
3634

3735
async def add_peer(self, peer):
3836
logger.info("Connecting to peer {}".format(peer))

receptor/entrypoints.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ async def node_keepalive():
3131
start_http_server(config.node_stats_port)
3232
if not config.node_server_disable:
3333
controller.enable_server(config.node_listen)
34-
if config.node_websocket_listen:
35-
controller.enable_websocket_server(config.node_websocket_listen)
3634
for peer in config.node_peers:
3735
controller.loop.create_task(controller.add_peer(peer))
3836
if config.node_keepalive_interval > 1:

0 commit comments

Comments
 (0)