Skip to content

Commit bcd7517

Browse files
authored
Merge pull request #24 from matburt/error_logging
Small updates to error logging
2 parents 7f46155 + dd39f9b commit bcd7517

4 files changed

Lines changed: 5 additions & 2 deletions

File tree

receptor/__main__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def main(args=None):
3232
'loggers': {
3333
'receptor': {
3434
'handlers': ['console'],
35-
'level': 'DEBUG' if config.default_debug else 'INFO',
35+
'level': 'DEBUG' if config.default_debug else 'WARN',
3636
},
3737
},
3838
}

receptor/config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ def _enforce_value_type(self, value, value_type):
377377
raise Exception("could not convert '%s' (type: %s) to a boolean value" % (value, type(value)))
378378
elif value_type == 'path':
379379
# FIXME: implement, or do we care if it's really a path and not just a string?
380-
return value
380+
return os.path.expanduser(value)
381381
else:
382382
return value
383383
except Exception as e:

receptor/router.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ async def send(self, inner_envelope, expected_response=False):
164164
"""
165165
next_node_id = self.next_hop(inner_envelope.recipient)
166166
if not next_node_id:
167+
#TODO: This probably needs to emit an error response
167168
raise UnrouteableError(f'No route found to {inner_envelope.recipient}')
168169
signed = await inner_envelope.sign_and_serialize()
169170
outer_envelope = envelope.OuterEnvelope(

receptor/work.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import logging
2+
import traceback
23
import pkg_resources
34

45
from . import exceptions
@@ -44,6 +45,7 @@ async def handle(self, inner_env):
4445
except Exception as e:
4546
serial += 1
4647
logger.error(f'Error encountered while handling the response, replying with an error message ({e})')
48+
logger.error(traceback.format_tb(e.__traceback__))
4749
enveloped_response = envelope.InnerEnvelope.make_response(
4850
receptor=self.receptor,
4951
recipient=inner_env.sender,

0 commit comments

Comments
 (0)