Skip to content

Commit 73f82e4

Browse files
committed
adding some documentation
Signed-off-by: Jesse Jaggars <jjaggars@redhat.com>
1 parent 7410565 commit 73f82e4

2 files changed

Lines changed: 18 additions & 8 deletions

File tree

receptor/buffers/file.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@ def __init__(self, dir_, key, loop):
2727
pass
2828
for item in self._read_manifest():
2929
self.q.put_nowait(item)
30-
30+
3131
async def put(self, data):
3232
ident = str(uuid.uuid4())
3333
await self._loop.run_in_executor(pool, self._write_file, data, ident)
3434
await self.q.put(ident)
3535
await self._save_manifest()
36-
36+
3737
async def get(self, handle_only=False, delete=True):
3838
while True:
3939
msg = await self.q.get()
@@ -42,15 +42,15 @@ async def get(self, handle_only=False, delete=True):
4242
return await self._get_file(msg, handle_only=handle_only, delete=delete)
4343
except FileNotFoundError:
4444
pass
45-
45+
4646
async def _save_manifest(self):
4747
async with self._manifest_lock:
4848
await self._loop.run_in_executor(pool, self._write_manifest)
49-
49+
5050
def _write_manifest(self):
5151
with open(self._manifest_path, "w") as fp:
5252
json.dump(list(self.q._queue), fp)
53-
53+
5454
def _read_manifest(self):
5555
try:
5656
with open(self._manifest_path, "r") as fp:

receptor/messages/envelope.py

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
class FramedMessage:
1717
"""
18-
A complete message constructed from one or more Frames.
18+
A complete, two-part message.
1919
"""
2020

2121
__slots__ = ("msg_id", "header", "payload")
@@ -27,7 +27,6 @@ def __init__(self, msg_id=None, header=None, payload=None):
2727
self.header = header
2828
self.payload = payload
2929

30-
3130
def serialize(self):
3231
h = json.dumps(self.header).encode("utf-8")
3332
return b''.join([
@@ -39,6 +38,10 @@ def serialize(self):
3938

4039

4140
class CommandMessage(FramedMessage):
41+
"""
42+
A complete, single part message, meant to encapsulate point to point
43+
commands or naive broadcasts.
44+
"""
4245

4346
def serialize(self):
4447
h = json.dumps(self.header).encode("utf-8")
@@ -116,6 +119,12 @@ async def get(self):
116119

117120

118121
class Frame:
122+
"""
123+
A Frame represents the minimal metadata about a transmission.
124+
125+
Usually you should not create one directly, but rather use the
126+
FramedMessage or CommandMessage classes.
127+
"""
119128

120129
class Types(IntEnum):
121130
HEADER = 0
@@ -126,7 +135,6 @@ class Types(IntEnum):
126135

127136
__slots__ = ('type', 'version', 'length', 'msg_id', 'id')
128137

129-
130138
def __init__(self, type_, version, length, msg_id, id_):
131139
self.type = type_
132140
self.version = version
@@ -164,10 +172,12 @@ def wrap(cls, data, type_=Types.PAYLOAD, msg_id=None):
164172

165173

166174
def split_uuid(data):
175+
"Splits a 128 bit int into two 64 bit words for binary encoding"
167176
return ((data >> 64) & MAX_INT64, data & MAX_INT64)
168177

169178

170179
def join_uuid(hi, lo):
180+
"Joins two 64 bit words into a 128bit int from binary encoding"
171181
return (hi << 64) | lo
172182

173183

0 commit comments

Comments
 (0)