chore: improvements on message handling to not allow null

Author: andrepimpao

src/Rule/GreaterThan.php

@@ -6,11 +6,13 @@
 
 class GreaterThan extends AbstractRule implements RuleInterface
 {
+    private string $message;
+
     public function __construct(
         private readonly mixed $constraint,
-        private ?string $message = null)
+        string $message = null)
     {
-        $this->message ??= 'The "{{ name }}" value should be greater than "{{ constraint }}", "{{ value }}" given.';
+        $this->message = $message ?? 'The "{{ name }}" value should be greater than "{{ constraint }}", "{{ value }}" given.';
     }
 
     /**
@@ -40,17 +42,17 @@ public function validate(mixed $value): void
         }
     }
 
-    protected function canBeCompared(mixed $constraint, mixed $value): bool
+    protected function canBeCompared(mixed $value1, mixed $value2): bool
     {
-        if ($constraint instanceof \DateTimeInterface && $value instanceof \DateTimeInterface) {
+        if ($value1 instanceof \DateTimeInterface && $value2 instanceof \DateTimeInterface) {
             return true;
         }
 
-        if (\is_numeric($constraint) && \is_numeric($value)) {
+        if (\is_numeric($value1) && \is_numeric($value2)) {
             return true;
         }
 
-        if (\is_string($constraint) && \is_string($value)) {
+        if (\is_string($value1) && \is_string($value2)) {
             return true;
         }
 

src/Rule/NotBlank.php

@@ -6,21 +6,20 @@
 
 class NotBlank extends AbstractRule implements RuleInterface
 {
-    public function __construct(private ?string $message = null)
+    private string $message;
+
+    public function __construct(string $message = null)
     {
-        $this->message ??= 'The "{{ name }}" value should not be blank, "{{ value }}" given.';
+        $this->message = $message ?? 'The "{{ name }}" value should not be blank, "{{ value }}" given.';
     }
 
     /**
      * @throws NotBlankException
      */
     public function validate(mixed $value): void
     {
-        // Keep value unchanged for parameters
-        $input = $value;
-
         // Do not allow null, false, [] and ''
-        if ($input === false || (empty($input) && $input != '0')) {
+        if ($value === false || (empty($value) && $value != '0')) {
             throw new NotBlankException(
                 message: $this->message,
                 parameters: [