chore: changed default country error message

Author: andrepimpao

src/Rule/Country.php

@@ -17,7 +17,7 @@ class Country extends AbstractRule implements RuleInterface
         self::ALPHA_3_CODE
     ];
 
-    private string $message = 'The {{ name }} value is not a valid {{ code }} country code, {{ value }} given.';
+    private string $message = 'The {{ name }} value is not a valid country, {{ value }} given.';
 
     public function __construct(
         private readonly string $code = self::ALPHA_2_CODE,
@@ -37,8 +37,8 @@ public function assert(mixed $value, ?string $name = null): void
             throw new UnexpectedTypeException('string', get_debug_type($value));
         }
 
-        // Keep original value for parameters
-        $input = strtoupper($value);
+        // keep original value for parameters
+        $input = \strtoupper($value);
 
         if (
             ($this->code === self::ALPHA_2_CODE && !Countries::exists($input))

tests/CountryTest.php

@@ -21,26 +21,26 @@ public static function provideRuleUnexpectedValueData(): \Generator
         $unexpectedCodeMessage = '/Invalid code "(.*)"\. Accepted values are\: "(.*)"\./';
         $unexpectedTypeMessage = '/Expected value of type "string", (.*) given\./';
 
-        yield 'invalid code' => [new Country('invalid'), 'PT', $unexpectedCodeMessage];
+        yield 'invalid code' => [new Country('invalid'), 'pt', $unexpectedCodeMessage];
         yield 'invalid type' => [new Country(), 123, $unexpectedTypeMessage];
     }
 
     public static function provideRuleFailureConditionData(): \Generator
     {
         $exception = CountryException::class;
-        $message = '/The (.*) value is not a valid (.*) country code, (.*) given\./';
+        $message = '/The (.*) value is not a valid country, (.*) given\./';
 
         yield 'default' => [new Country(), 'PRT', $exception, $message];
-        yield 'alpha2' => [new Country(code: 'alpha-2'), 'PRT', $exception, $message];
-        yield 'alpha3' => [new Country(code: 'alpha-3'), 'PT', $exception, $message];
+        yield 'alpha2' => [new Country(code: 'alpha-2'), 'prt', $exception, $message];
+        yield 'alpha3' => [new Country(code: 'alpha-3'), 'pt', $exception, $message];
     }
 
     public static function provideRuleSuccessConditionData(): \Generator
     {
-        yield 'default' => [new Country(), 'PT'];
-        yield 'alpha2' => [new Country(code: 'alpha-2'), 'PT'];
+        yield 'default' => [new Country(), 'pt'];
+        yield 'alpha2' => [new Country(code: 'alpha-2'), 'pt'];
         yield 'alpha2 lowercase' => [new Country(code: 'alpha-2'), 'pt'];
-        yield 'alpha3' => [new Country(code: 'alpha-3'), 'PRT'];
+        yield 'alpha3' => [new Country(code: 'alpha-3'), 'prt'];
         yield 'alpha3 lowercase' => [new Country(code: 'alpha-3'), 'prt'];
     }
 

tests/TimezoneTest.php

@@ -19,15 +19,15 @@ class TimezoneTest extends AbstractTest
     public static function provideRuleUnexpectedValueData(): \Generator
     {
         $unexpectedMissingCountryCodeMessage = '/A country code is required when timezone group is "\\\DateTimeZone::PER_COUNTRY"\./';
-        $unexpectedCountryCodeMessage = '/The (.*) value is not a valid (.*) country code, (.*) given\./';
+        $unexpectedCountryCodeMessage = '/The (.*) value is not a valid country, (.*) given\./';
 
         yield 'missing country code' => [
             new Timezone(\DateTimeZone::PER_COUNTRY),
             'Europe/Lisbon',
             $unexpectedMissingCountryCodeMessage
         ];
         yield 'invalid country code' => [
-            new Timezone(\DateTimeZone::PER_COUNTRY, 'PRT'),
+            new Timezone(\DateTimeZone::PER_COUNTRY, 'prt'),
             'Europe/Lisbon',
             $unexpectedCountryCodeMessage
         ];