Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Commit 2ad4d0c

Browse files
committed
chore: minor data provider naming improvement
1 parent 235b34e commit 2ad4d0c

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

src/Test/Util/TestRuleFailureConditionTrait.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77

88
trait TestRuleFailureConditionTrait
99
{
10-
public static abstract function provideFailureConditionData(): \Generator;
10+
public static abstract function provideRuleFailureConditionData(): \Generator;
1111

12-
#[DataProvider('provideFailureConditionData')]
12+
#[DataProvider('provideRuleFailureConditionData')]
1313
public function testRuleFailureCondition(
1414
RuleInterface $rule,
1515
mixed $value,

src/Test/Util/TestRuleSuccessConditionTrait.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77

88
trait TestRuleSuccessConditionTrait
99
{
10-
public static abstract function provideSuccessConditionData(): \Generator;
10+
public static abstract function provideRuleSuccessConditionData(): \Generator;
1111

12-
#[DataProvider('provideSuccessConditionData')]
12+
#[DataProvider('provideRuleSuccessConditionData')]
1313
public function testRuleSuccessCondition(RuleInterface $rule, mixed $value): void
1414
{
1515
$rule->assert($value, 'test');

tests/GreaterThanTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class GreaterThanTest extends AbstractTest
1212
use TestRuleFailureConditionTrait;
1313
use TestRuleSuccessConditionTrait;
1414

15-
public static function provideFailureConditionData(): \Generator
15+
public static function provideRuleFailureConditionData(): \Generator
1616
{
1717
$exception = GreaterThanException::class;
1818
$exceptionMessageInvalid = '/Cannot compare a type "(.*)" with a type "(.*)"/';
@@ -27,7 +27,7 @@ public static function provideFailureConditionData(): \Generator
2727
yield 'null constraint' => [new GreaterThan(null), 10, $exception, $exceptionMessageInvalid];
2828

2929
yield 'datetime' => [new GreaterThan(new \DateTime('today')), new \DateTime('yesterday'), $exception, $exceptionMessageFailure];
30-
yield 'same datetime' => [new GreaterThan(new \DateTime('2000-01-01')), new \DateTime('2000-01-01'), $exception, $exceptionMessageFailure];
30+
yield 'same datetime' => [new GreaterThan(new \DateTime('today')), new \DateTime('today'), $exception, $exceptionMessageFailure];
3131
yield 'int' => [new GreaterThan(10), 1, $exception, $exceptionMessageFailure];
3232
yield 'same int' => [new GreaterThan(10), 10, $exception, $exceptionMessageFailure];
3333
yield 'float' => [new GreaterThan(10.0), 1.0, $exception, $exceptionMessageFailure];
@@ -38,7 +38,7 @@ public static function provideFailureConditionData(): \Generator
3838
yield 'same string' => [new GreaterThan('a'), 'a', $exception, $exceptionMessageFailure];
3939
}
4040

41-
public static function provideSuccessConditionData(): \Generator
41+
public static function provideRuleSuccessConditionData(): \Generator
4242
{
4343
yield 'datetime' => [new GreaterThan(new \DateTime('today')), new \DateTime('tomorrow')];
4444
yield 'int' => [new GreaterThan(10), 20];

tests/NotBlankTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class NotBlankTest extends AbstractTest
1212
use TestRuleFailureConditionTrait;
1313
use TestRuleSuccessConditionTrait;
1414

15-
public static function provideFailureConditionData(): \Generator
15+
public static function provideRuleFailureConditionData(): \Generator
1616
{
1717
$exception = NotBlankException::class;
1818
$exceptionMessage = '/The "(.*)" value should not be blank, "(.*)" given./';
@@ -23,7 +23,7 @@ public static function provideFailureConditionData(): \Generator
2323
yield 'blank array' => [new NotBlank(), [], $exception, $exceptionMessage];
2424
}
2525

26-
public static function provideSuccessConditionData(): \Generator
26+
public static function provideRuleSuccessConditionData(): \Generator
2727
{
2828
yield 'true' => [new NotBlank(), true];
2929

0 commit comments

Comments
 (0)