Skip to content

Commit b4ae94d

Browse files
josephperrottAndrewKushnir
authored andcommitted
refactor: remove TODOs which have been corrected (angular#63421)
Remove TODOs which were addressed but the comment was not removed PR Close angular#63421
1 parent 0133964 commit b4ae94d

5 files changed

Lines changed: 1 addition & 12 deletions

File tree

adev/shared-docs/components/viewers/example-viewer/example-viewer.component.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ describe('ExampleViewer', () => {
3535
await TestBed.configureTestingModule({
3636
imports: [ExampleViewer],
3737
providers: [
38-
// TODO: Find why tests warn that zone.js is still loaded
3938
provideZonelessChangeDetection(),
4039
{provide: EXAMPLE_VIEWER_CONTENT_LOADER, useValue: exampleContentSpy},
4140
{provide: ActivatedRoute, useValue: {snapshot: {fragment: 'fragment'}}},

adev/shared-docs/pipeline/api-gen/rendering/index.mts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,6 @@ async function main() {
103103

104104
const [srcs, outputFilenameExecRootRelativePath] = rawParamLines;
105105

106-
// TODO: Remove when we are using Bazel v6+
107-
// On RBE, the output directory is not created properly due to a bug.
108-
// https://github.com/bazelbuild/bazel/commit/4310aeb36c134e5fc61ed5cdfdf683f3e95f19b7.
109-
if (!existsSync(outputFilenameExecRootRelativePath)) {
110-
mkdirSync(outputFilenameExecRootRelativePath, {recursive: true});
111-
}
112-
113106
// Docs rendering happens in three phases that occur here:
114107
// 1) Aggregate all the raw extracted doc info.
115108
// 2) Transform the raw data to a renderable state.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"extends": "./tsconfig.json",
33
"compilerOptions": {
4-
"types": ["jasmine", "node"],
4+
"types": ["node"],
55
"paths": {}
66
}
77
}

packages/common/http/test/BUILD.bazel

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,10 @@ angular_jasmine_test(
2525
data = [
2626
":test_lib",
2727
],
28-
flaky = True, # TODO: figure out why one of the transferCache tests is flaky
2928
)
3029

3130
ng_web_test_suite(
3231
name = "test_web",
33-
flaky = True, # TODO: figure out why one of the transferCache tests is flaky
3432
deps = [
3533
":test_lib",
3634
],

packages/common/http/test/transfer_cache_spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,6 @@ describe('TransferCache', () => {
272272
makeRequestAndExpectOne('/test-1?foo=1', 'foo', {method: 'POST'});
273273
});
274274

275-
// TODO: Investigate why this test is flaky
276275
it('should cache POST with the transferCache option', () => {
277276
makeRequestAndExpectOne('/test-1?foo=1', 'foo', {method: 'POST', transferCache: true});
278277
makeRequestAndExpectNone('/test-1?foo=1', 'POST', {transferCache: true});

0 commit comments

Comments
 (0)