Skip to content

Commit 0ad18ee

Browse files
hawkgsleonsenft
authored andcommitted
refactor(devtools): drop explicit OnPush change detection strategy
Drop explicit `ChangeDetectionStrategy.OnPush` from the apps since it's now the default.
1 parent 9ee4f83 commit 0ad18ee

46 files changed

Lines changed: 33 additions & 163 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

devtools/projects/ng-devtools/src/lib/devtools-tabs/devtools-tabs.component.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,7 @@
66
* found in the LICENSE file at https://angular.dev/license
77
*/
88

9-
import {
10-
ChangeDetectionStrategy,
11-
Component,
12-
computed,
13-
inject,
14-
input,
15-
output,
16-
signal,
17-
} from '@angular/core';
9+
import {Component, computed, inject, input, output, signal} from '@angular/core';
1810
import {MatIcon} from '@angular/material/icon';
1911
import {MatMenu, MatMenuItem, MatMenuTrigger} from '@angular/material/menu';
2012
import {MatSlideToggle} from '@angular/material/slide-toggle';
@@ -67,7 +59,6 @@ type Tab = 'Components' | 'Profiler' | 'Router Tree' | 'Injector Tree' | 'Transf
6759
ButtonComponent,
6860
],
6961
providers: [TabUpdate],
70-
changeDetection: ChangeDetectionStrategy.OnPush,
7162
})
7263
export class DevToolsTabsComponent {
7364
public readonly frameManager = inject(FrameManager);

devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/directive-explorer.component.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import {
1515
output,
1616
signal,
1717
viewChild,
18-
ChangeDetectionStrategy,
1918
computed,
2019
DestroyRef,
2120
} from '@angular/core';
@@ -37,7 +36,7 @@ import {FrameManager} from '../../application-services/frame_manager';
3736
import {BreadcrumbsComponent} from './directive-forest/breadcrumbs/breadcrumbs.component';
3837
import {FlatNode} from './directive-forest/component-data-source';
3938
import {DirectiveForestComponent} from './directive-forest/directive-forest.component';
40-
import {findNodeByPosition, IndexedNode, indexForest} from './directive-forest/index-forest';
39+
import {IndexedNode} from './directive-forest/index-forest';
4140
import {constructPathOfKeysToPropertyValue} from './property-resolver/directive-property-resolver';
4241
import {ElementPropertyResolver} from './property-resolver/element-property-resolver';
4342
import {FlatNode as PropertyFlatNode} from '../../shared/object-tree-explorer/object-tree-types';
@@ -99,7 +98,6 @@ const sameDirectives = (a: IndexedNode, b: IndexedNode) => {
9998
SignalGraphPaneComponent,
10099
ResponsiveSplitDirective,
101100
],
102-
changeDetection: ChangeDetectionStrategy.OnPush,
103101
})
104102
export class DirectiveExplorerComponent {
105103
readonly showCommentNodes = input(false);

devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/directive-forest/breadcrumbs/breadcrumbs.component.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
*/
88

99
import {
10-
ChangeDetectionStrategy,
1110
Component,
1211
computed,
1312
effect,
@@ -26,7 +25,6 @@ import {MatIcon} from '@angular/material/icon';
2625
templateUrl: './breadcrumbs.component.html',
2726
styleUrls: ['./breadcrumbs.component.scss'],
2827
imports: [MatIcon],
29-
changeDetection: ChangeDetectionStrategy.OnPush,
3028
})
3129
export class BreadcrumbsComponent {
3230
readonly parents = input.required<FlatNode[]>();

devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/directive-forest/directive-forest.component.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import {
1414
import {FlatTreeControl} from '@angular/cdk/tree';
1515
import {
1616
afterRenderEffect,
17-
ChangeDetectionStrategy,
1817
Component,
1918
computed,
2019
DestroyRef,
@@ -45,7 +44,6 @@ const RESIZE_OBSERVER_DEBOUNCE = 250; // ms
4544
selector: 'ng-directive-forest',
4645
templateUrl: './directive-forest.component.html',
4746
styleUrls: ['./directive-forest.component.scss'],
48-
changeDetection: ChangeDetectionStrategy.OnPush,
4947
imports: [
5048
FilterComponent,
5149
CdkVirtualScrollViewport,

devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/directive-forest/filter/filter.component.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,7 @@
66
* found in the LICENSE file at https://angular.dev/license
77
*/
88

9-
import {
10-
ChangeDetectionStrategy,
11-
Component,
12-
ElementRef,
13-
input,
14-
output,
15-
viewChild,
16-
} from '@angular/core';
9+
import {Component, ElementRef, input, output, viewChild} from '@angular/core';
1710
import {MatIcon} from '@angular/material/icon';
1811
import {MatTooltip} from '@angular/material/tooltip';
1912

@@ -52,7 +45,6 @@ const genericSearchGenerator: FilterFnGenerator = (filter: string) => {
5245
templateUrl: './filter.component.html',
5346
styleUrls: ['./filter.component.scss'],
5447
imports: [MatIcon, MatTooltip],
55-
changeDetection: ChangeDetectionStrategy.OnPush,
5648
})
5749
export class FilterComponent {
5850
protected readonly input = viewChild.required<ElementRef>('input');

devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/directive-forest/tree-node/tree-node.component.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
import {
1010
afterRenderEffect,
11-
ChangeDetectionStrategy,
1211
Component,
1312
computed,
1413
ElementRef,
@@ -39,7 +38,6 @@ export type NodeTextMatch = {
3938
selector: 'ng-tree-node',
4039
templateUrl: './tree-node.component.html',
4140
styleUrls: ['./tree-node.component.scss'],
42-
changeDetection: ChangeDetectionStrategy.OnPush,
4341
imports: [MatIcon, MatTooltip],
4442
host: {
4543
'[style.padding-left]': 'paddingLeft()',

devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-pane/defer-view/defer-view.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* found in the LICENSE file at https://angular.dev/license
77
*/
88

9-
import {ChangeDetectionStrategy, Component, computed, input} from '@angular/core';
9+
import {Component, computed, input} from '@angular/core';
1010
import {MatToolbar} from '@angular/material/toolbar';
1111
import {DeferBlock} from '../../../../../../../protocol';
1212

@@ -15,7 +15,6 @@ import {DeferBlock} from '../../../../../../../protocol';
1515
selector: 'ng-defer-view',
1616
styleUrls: ['./defer-view.component.scss', '../styles/view-tab.scss'],
1717
imports: [MatToolbar],
18-
changeDetection: ChangeDetectionStrategy.OnPush,
1918
})
2019
export class DeferViewComponent {
2120
readonly defer = input.required<NonNullable<DeferBlock>>();

devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-pane/for-loop-view/for-loop-view.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* found in the LICENSE file at https://angular.dev/license
77
*/
88

9-
import {ChangeDetectionStrategy, Component, computed, input} from '@angular/core';
9+
import {Component, computed, input} from '@angular/core';
1010
import {MatExpansionModule} from '@angular/material/expansion';
1111
import {ForLoopBlock} from '../../../../../../../protocol';
1212
import {ObjectTreeExplorerComponent} from '../../../../shared/object-tree-explorer/object-tree-explorer.component';
@@ -19,7 +19,6 @@ import {MatToolbar} from '@angular/material/toolbar';
1919
selector: 'ng-for-loop-view',
2020
styleUrls: ['./for-loop-view.component.scss', '../styles/view-tab.scss'],
2121
imports: [MatExpansionModule, ObjectTreeExplorerComponent, MatToolbar],
22-
changeDetection: ChangeDetectionStrategy.OnPush,
2322
})
2423
export class ForLoopViewComponent {
2524
protected readonly forLoop = input.required<NonNullable<ForLoopBlock>>();

devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-pane/property-pane-header/component-metadata/component-metadata.component.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,7 @@
66
* found in the LICENSE file at https://angular.dev/license
77
*/
88

9-
import {
10-
ChangeDetectionStrategy,
11-
Component,
12-
ɵFramework as Framework,
13-
computed,
14-
inject,
15-
input,
16-
} from '@angular/core';
9+
import {Component, ɵFramework as Framework, computed, inject, input} from '@angular/core';
1710

1811
import {
1912
AcxDirectiveMetadata,
@@ -29,7 +22,6 @@ import {ElementPropertyResolver} from '../../../property-resolver/element-proper
2922
templateUrl: './component-metadata.component.html',
3023
styleUrls: ['./component-metadata.component.scss'],
3124
imports: [DocsRefButtonComponent],
32-
changeDetection: ChangeDetectionStrategy.OnPush,
3325
})
3426
export class ComponentMetadataComponent {
3527
readonly currentSelectedComponent = input.required<ComponentType>();

devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-pane/property-pane-header/property-pane-header.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* found in the LICENSE file at https://angular.dev/license
77
*/
88

9-
import {ChangeDetectionStrategy, Component, input, output, signal, inject} from '@angular/core';
9+
import {Component, input, output, signal, inject} from '@angular/core';
1010
import {MatExpansionModule} from '@angular/material/expansion';
1111
import {MatIcon} from '@angular/material/icon';
1212

@@ -19,7 +19,6 @@ import {SUPPORTED_APIS} from '../../../../application-providers/supported_apis';
1919
templateUrl: './property-pane-header.component.html',
2020
selector: 'ng-property-pane-header',
2121
styleUrls: ['./property-pane-header.component.scss'],
22-
changeDetection: ChangeDetectionStrategy.OnPush,
2322
imports: [MatExpansionModule, MatIcon, ComponentMetadataComponent, ButtonComponent],
2423
})
2524
export class PropertyPaneHeaderComponent {

0 commit comments

Comments
 (0)