Merge pull request #59 from posthtml/milestone-2.0.4

Scrum · web-flow · commit 9fb93689a334 · 2021-06-08T12:02:38.000+03:00
Milestone 2.0.4
diff --git a/changelog.md b/changelog.md
@@ -1,5 +1,14 @@
+## <small>2.0.4 (2021-06-08)</small>
+
+* perf: engine up to 12 version ([7c430be](https://github.com/posthtml/posthtml-render/commit/7c430be))
+* fix: if tree contains empty string, close #58 ([401f5a6](https://github.com/posthtml/posthtml-render/commit/401f5a6)), closes [#58](https://github.com/posthtml/posthtml-render/issues/58)
+* test: if tree exists empty string, issue #58 ([3493d4f](https://github.com/posthtml/posthtml-render/commit/3493d4f)), closes [#58](https://github.com/posthtml/posthtml-render/issues/58)
+
+
+
 ## <small>2.0.3 (2021-06-04)</small>
 
+* 2.0.3 ([f5cd69d](https://github.com/posthtml/posthtml-render/commit/f5cd69d))
 * test: if in content has empty array, issue #56 ([95bad06](https://github.com/posthtml/posthtml-render/commit/95bad06)), closes [#56](https://github.com/posthtml/posthtml-render/issues/56)
 * fix: if in content has empty array, close #56 ([892d602](https://github.com/posthtml/posthtml-render/commit/892d602)), closes [#56](https://github.com/posthtml/posthtml-render/issues/56)
 
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,13 +1,13 @@
 {
   "name": "posthtml-render",
-  "version": "2.0.3",
+  "version": "2.0.4",
   "description": "Renders PostHTML Tree to HTML/XML",
   "license": "MIT",
   "repository": "posthtml/posthtml-render",
   "author": "Ivan Voischev <voischev.ivan@ya.ru>",
   "main": "dist/index.js",
   "engines": {
-    "node": ">=10"
+    "node": ">=12"
   },
   "scripts": {
     "version": "conventional-changelog -i changelog.md -s -r 0 && git add changelog.md",
diff --git a/src/index.ts b/src/index.ts
@@ -80,7 +80,7 @@ function render(tree?: Node | Node[], options: Options = {}): string {
         (typeof node === 'string' && node.length === 0) ||
         Number.isNaN(node)
       ) {
-        break;
+        continue;
       }
 
       // Treat as new root tree if node is an array
diff --git a/test/test-core.spec.ts b/test/test-core.spec.ts
@@ -237,6 +237,48 @@ test('{Tree} {Immutable}', t => {
   t.is(html1, html2);
 });
 
+test('{Tree} {With empty string}', t => {
+  const tree = [
+    '',
+    '<!doctype html>',
+    '',
+    {
+      tag: 'html',
+      attrs: {
+        lang: 'en'
+      },
+      content: [
+        '',
+        {
+          tag: 'head',
+          content: [
+            '',
+            {
+              tag: 'meta',
+              attrs: {
+                charset: 'utf-8'
+              }
+            },
+            ''
+          ]
+        },
+        '',
+        {
+          tag: 'body',
+          content: [
+            ' '
+          ]
+        },
+        ''
+      ]
+    },
+    ''
+  ];
+  const html = '<!doctype html><html lang="en"><head><meta charset="utf-8"></head><body> </body></html>';
+
+  t.is(render(tree), html);
+});
+
 test('{Options} {singleTag} Defaults', t => {
   const SINGLE_TAGS_LOWERCASE = [
     'area', 'base', 'br', 'col', 'command', 'embed', 'hr', 'img', 'input', 'keygen', 'link', 'menuitem', 'meta', 'param', 'source', 'track', 'wbr'

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ function render(tree?: Node \| Node[], options: Options = {}): string {`
`80`	`80`	`(typeof node === 'string' && node.length === 0) \|\|`
`81`	`81`	`Number.isNaN(node)`
`82`	`82`	`) {`
`83`		`- break;`
	`83`	`+ continue;`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`// Treat as new root tree if node is an array`