PostgresConfigurationFactory_Base is corrected (#25)

- Helper__CreateObject uses compares types via "is"
- fix: Helper__CreateFileLine returns PostgresConfigurationFileLine_Base
- fix: Helper__CreateOption returns PostgresConfigurationOption_Base
- del: Helper__CreateFileLineComment

Author: dmitry-lipetsk

src/implementation/v00/configuration_base.py

@@ -3096,23 +3096,20 @@ def Helper__CreateObject(
             objectParent, PostgresConfigurationObject
         )
 
-        typeOfObjectData = type(objectData)
-        assert typeOfObjectData is not None
-
-        if typeOfObjectData == PgCfgModel__ConfigurationData:
+        if type(objectData) is PgCfgModel__ConfigurationData:
             assert objectData is cfg.m_Data
             return cfg
 
-        if typeOfObjectData == PgCfgModel__FileData:
+        if type(objectData) is PgCfgModel__FileData:
             return __class__.Helper__CreateFile(objectData, objectParent)
 
-        if typeOfObjectData == PgCfgModel__FileLineData:
+        if type(objectData) is PgCfgModel__FileLineData:
             return __class__.Helper__CreateFileLine(objectData, objectParent)
 
-        if typeOfObjectData == PgCfgModel__OptionData:
+        if type(objectData) is PgCfgModel__OptionData:
             return __class__.Helper__CreateOption(objectData, objectParent)
 
-        BugCheckError.UnkObjectDataType(typeOfObjectData)
+        BugCheckError.UnkObjectDataType(type(objectData))
 
     # --------------------------------------------------------------------
     @staticmethod
@@ -3137,33 +3134,20 @@ def Helper__CreateFile(
     def Helper__CreateFileLine(
         objectData: PgCfgModel__FileLineData,
         objectParent: PostgresConfigurationObject,
-    ) -> PostgresConfigurationFile_Base:
+    ) -> PostgresConfigurationFileLine_Base:
         assert objectData is not None
         assert objectParent is not None
         assert type(objectData) is PgCfgModel__FileLineData
         assert isinstance(objectParent, PostgresConfigurationFile_Base)
 
         return PostgresConfigurationFileLine_Base(objectParent, objectData)
 
-    # --------------------------------------------------------------------
-    @staticmethod
-    def Helper__CreateFileLineComment(
-        fileLineDataItem: PgCfgModel__FileLineData.tagItem,
-        fileLine: PostgresConfigurationObject,
-    ) -> PostgresConfigurationFile_Base:
-        assert fileLineDataItem is not None
-        assert fileLine is not None
-        assert type(fileLineDataItem) is PgCfgModel__FileLineData.tagItem
-        assert isinstance(fileLine, PostgresConfigurationFileLine_Base)
-
-        return PostgresConfigurationComment_Base(fileLine, fileLineDataItem)
-
     # --------------------------------------------------------------------
     @staticmethod
     def Helper__CreateOption(
         objectData: PgCfgModel__OptionData,
         objectParent: PostgresConfigurationObject,
-    ) -> PostgresConfigurationFile_Base:
+    ) -> PostgresConfigurationOption_Base:
         assert objectData is not None
         assert objectParent is not None
         assert type(objectData) is PgCfgModel__OptionData