You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unify line and path renderers into single PathRenderer
Remove LineRenderer and consolidate all line/path rendering logic into
PathRenderer. Both geom types were already functionally identical:
- Both map to "line" mark in Vega-Lite
- Both add order encoding to preserve data order
- Both need identical material aesthetic handling
Changes:
- Remove LineRenderer struct
- PathRenderer now handles both line and path geoms
- Updated get_renderer() to return PathRenderer for both GeomType::Line and GeomType::Path
- Updated documentation to reflect unified renderer
This eliminates code duplication while maintaining all functionality. The actual
sorting/ordering happens in the execute phase via SQL ORDER BY, and both geoms
preserve that order through the __ggsql_row_index__ column.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
0 commit comments