Set up Dangerfile

Author: bcylin

.travis.yml

@@ -2,12 +2,13 @@ language: objective-c
 osx_image: xcode8
 matrix:
   include:
-    - env: BUILD=9.3
-      script: bundle exec rake ci:build[9.3]
-    - env: BUILD=latest
-      script: bundle exec rake ci:build[latest]
-    - env: BUILD=carthage
-      script: make carthage
+    - env: VERSION=9.3
+    - env: VERSION=latest
+    - env: VERSION=carthage
+      before_script:
+        - bundle exec danger
+      script:
+        - make carthage
       after_script:
         - make documentation
 cache:
@@ -21,6 +22,8 @@ install:
   - make install
 before_script:
   - xcodebuild -workspace ICInputAccessory.xcworkspace -list
+script:
+  - bundle exec rake ci:build[$VERSION]
 notifications:
   email: false
   slack:

Dangerfile

@@ -0,0 +1,25 @@
+#!/usr/bin/env ruby
+
+# Sometimes it's a README fix, or something like that - which isn't relevant for
+# including in a project's CHANGELOG for example
+declared_trivial = pr_title.include? "#trivial"
+
+# Make it more obvious that a PR is a work in progress and shouldn't be merged yet
+warn("PR is classed as Work in Progress") if pr_title.include? "[WIP]"
+
+# Warn when there is a big PR
+warn("Big PR") if lines_of_code > 500
+
+# Don't let testing shortcuts get into master by accident
+fail("fdescribe left in tests") if `grep -r fdescribe specs/`.length > 1
+fail("fit left in tests") if `grep -r "fit specs/ `.length > 1
+
+# Add a CHANGELOG entry for app changes
+if git.lines_of_code > 50 && !github.modified_files.include?("CHANGELOG.md") && !declared_trivial
+  fail("Please update [CHANGELOG.md](https://github.com/polydice/ICInputAccessory/blob/develop/CHANGELOG.md).")
+end
+
+# Ensure a clean commits history
+if git.commits.any? { |c| c.message =~ /^Merge branch/ }
+  fail('Please rebase to get rid of the merge commits in this PR')
+end